After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 758010 - mpegtsdemux: stream->section_data leak if there is a stream discontinuity
mpegtsdemux: stream->section_data leak if there is a stream discontinuity
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.7.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-11-12 15:42 UTC by Nicolas Huet
Modified: 2015-11-13 08:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch removing the leak (1.31 KB, patch)
2015-11-12 15:42 UTC, Nicolas Huet 		committed Details | Review

Description Nicolas Huet 2015-11-12 15:42:56 UTC 
Created attachment 315346 [details] [review]
patch removing the leak

If packet->payload_unit_start_indicator is true and pointer 0, there is no discontinuity check. Therefore there could be a previous section not complete that need to be cleared.

I have attached a patch that fix the issue.

In the function mpegts_packetizer_stream_free, I have also removed the free on section_data which is already done in mpegts_packetizer_clear_section
Comment 1 Sebastian Dröge (slomo) 2015-11-13 08:38:49 UTC 
commit d65d8657e64a387a87cdeb96e1b64fb640281166
Author: Nicolas Huet <nicolas.huet@parrot.com>
Date:   Thu Nov 12 16:35:12 2015 +0100

    mpegtsdemux: fix section_data leak
    
    If packet->payload_unit_start_indicator is true and pointer 0, there is no
    discontinuity check. Therefore there could be a previous section not complete
    that need to be cleared.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=758010