After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 757859 - adaptivedemux: memory leak in adaptive demux src bin
adaptivedemux: memory leak in adaptive demux src bin
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.7.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-11-09 22:56 UTC by Florin Apostol
Modified: 2015-11-10 10:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix pad memory leak (1.34 KB, patch)
2015-11-10 01:06 UTC, Vineeth 		committed Details | Review

Description Florin Apostol 2015-11-09 22:56:42 UTC 
The commit ccff3be3ab2e5bffcefc12c80a5edb225801f1b9 introduced a bin element in adaptivedemux. The bin element is holding the urihandler and a queue2 element.
After this change, all adaptive demux tests are leaking memory (some are actually failing, but that is covered in https://bugzilla.gnome.org/show_bug.cgi?id=757776) . The uri_handler and the queue2 element are leaking. The new bin element is not.

I don't know how to debug the reference count in these elements to figure out who is holding the references.
Comment 1 Vineeth 2015-11-10 01:06:35 UTC 
Created attachment 315164 [details] [review]
fix pad memory leak

The memory leak is happening because queue sink pad and uri handler src pad are being referenced but not getting freed.
Comment 2 Florin Apostol 2015-11-10 09:37:09 UTC 
Review of attachment 315164 [details] [review]:

looks great. Thank you.
Comment 3 Thiago Sousa Santos 2015-11-10 10:23:40 UTC 
commit d624ba0c61db6fd5137fb90d527e12bc04e8637d
Author: Vineeth TM <vineeth.tm@samsung.com>
Date:   Tue Nov 10 10:02:38 2015 +0900

    adaptivedemux: Fix pad memory leak.
    
    The static pads got from queue and uri_handler are not being freed
    resulting in memory leaks.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=757859