GNOME Bugzilla – Bug 757826
Provide a shortcuts window
Last modified: 2015-12-16 15:15:00 UTC
Since nautilus doesn't have a menu bar, it would be great to provide a GtkShortcutsWindow so that users can discover available keyboard shortcuts. More details can be found here: https://wiki.gnome.org/Initiatives/GnomeGoals/ShortcutWindows
A good thing for 3.20 since it doesn't introduce possible regressions.
Created attachment 315260 [details] [review] application: add shortcuts help window Use GTK+'s new shortcut window to document our shortcuts. See: https://wiki.gnome.org/Initiatives/GnomeGoals/ShortcutWindows
Created attachment 315262 [details] screenshot We might discuss which shortcuts are relevant for this component.
Great to see this! It would be good to have some more groups, to make it easier to navigate. Possibly something like this? General ------- Ctrl + T New tab Ctrl + W Close tab Ctrl + F Search F9 Show/hide sidebar Navigation ---------- Alt + < Go back Alt + > Go forward Alt + ^ Go up Alt + Home Go to home folder Opening ------- Enter / Ctrl + O Open Shift + Ctrl + T Open in new tab Shift + Ctrl + W Open in new window Editing ------- Shift + Ctrl + N Create folder F2 Rename Delete Move to trash Ctrl + C Copy Ctrl + V Paste Ctrl + A Select all Ctrl + S Select items matching View ---- Ctrl + + Zoom in Ctrl + - Zoom out Ctrl + R Refresh view Ctrl + H Show/hide hidden files
Oh and it's missing Ctrl + N for new window - probably needs to be the first shortcut in the general section.
Created attachment 315274 [details] [review] application: add shortcuts help window Use GTK+'s new shortcut window to document our shortcuts. See: https://wiki.gnome.org/Initiatives/GnomeGoals/ShortcutWindows
Created attachment 315275 [details] screenshot (page 1)
Created attachment 315276 [details] screenshot (page 2) We might want to position the groups in a different order.
Created attachment 315281 [details] [review] application: add shortcuts help window Use GTK+'s new shortcut window to document our shortcuts. See: https://wiki.gnome.org/Initiatives/GnomeGoals/ShortcutWindows
Created attachment 315282 [details] screenshot (page 1) reordered the groups.
Created attachment 315283 [details] screenshot (page 2)
It's missing F5 for refreshing (and sadly it's equally important as ctrl+r), ctrl+B for bookmarks (which is one of the things people don't know), invert selection, search, hamburger and view menu, tabs switching, view mode changes, media keys, etc. My concern it's mostly that if we use a shortcut window and we don't put some, people will think they don't exist (more than thinking they might exist, like the current situation). I would take an approach of put everything and then maybe remove some if we think it's not needed for some reason, what do you think Allan and Felipe?
Created attachment 315317 [details] [review] application: add shortcuts help window Use GTK+'s new shortcut window to document our shortcuts. See: https://wiki.gnome.org/Initiatives/GnomeGoals/ShortcutWindows
(In reply to Carlos Soriano from comment #12) ... > I would take an approach of put everything and then maybe remove some if we > think it's not needed for some reason, what do you think Allan and Felipe? Sounds like a good approach to me.
should we have an app-menu entry for the Keyboard Shortcuts window too?
(In reply to Felipe Borges from comment #15) > should we have an app-menu entry for the Keyboard Shortcuts window too? Sounds like a good idea to me.
Created attachment 315882 [details] [review] application: add shortcuts help window Use GTK+'s new shortcut window to document our shortcuts. See: https://wiki.gnome.org/Initiatives/GnomeGoals/ShortcutWindows
Created attachment 315887 [details] screenshot (page 1)
Created attachment 315889 [details] screenshot (page 2) it's a little crowded now. :)
(In reply to Felipe Borges from comment #18) > Created attachment 315887 [details] > screenshot (page 1) Looks alright to me!
list view <control>1 grid view <control>2 Delete permanently <shift>delete Open with default application <control>o and <alt>down I think those are the last ones that are missing.
Created attachment 316078 [details] [review] application: add shortcuts help window Use GTK+'s new shortcut window to document our shortcuts. See: https://wiki.gnome.org/Initiatives/GnomeGoals/ShortcutWindows
Review of attachment 316078 [details] [review]: LGTM, thanks!
Comment on attachment 316078 [details] [review] application: add shortcuts help window Thx! pushed to master at https://git.gnome.org/browse/nautilus/commit/?id=74da171b9647ab39849d062555cdd364dccb3678
Great, thanks Felipe and Carlos!
Some comments based on testing master today: * List view and grid view shortcuts should be under view, not navigation. * Invert selection shortcut should be in the editing section, with the other selection shortcuts. * The navigation section would benefit from better grouping - you could place all the "go" shortcuts together, and you could group all the location bar shortcuts together. * The navigation section is very long - since there are 5 tabs shortcuts, you could split them out into a separate Tabs section. * Ctrl+W is labeled "Close tab", but it also closes windows. * "Show bookmarks manager" seems odd - it isn't really a "view" shortcut. It might be better as "Bookmarks manager" and placed in the general section. * I wasn't able to work out what "Prompt root location" or "Prompt home location" meant - I had to try them to find out.
Created attachment 317356 [details] [review] help-overlay: reorganize shortcuts
Created attachment 317357 [details] screenshot (page 1)
Created attachment 317358 [details] screenshot (page 2)
I keep noticing new issues! * "Close Tab/Window" - "tab" and "window" shouldn't be capitalised. * Bookmark current location and show item properties don't really fit in a section called "Opening". Could possibly move the former into general and the latter into editing. * It isn't clear that "open item location" only works in the recent view and search results. Could expand the label - "Open item location (search and recent only)". * "Go to tab" should maybe be renamed to "Open tab". * "Bookmarks manager" should maybe be "Bookmarks"? * Reset zoom should be placed after the shortcuts for zoom in and zoom out. * Should add the shortcuts for the shortcuts window, after Help. They're Ctrl+? and Ctrl+F1. * Invert selection should be with the other selection shortcuts (probably after select all).
Created attachment 317375 [details] [review] help-overlay: reorganize shortcuts
Created attachment 317376 [details] screenshot (page 1)
Created attachment 317377 [details] screenshot (page 2)
Looks good to me! :) There are still some things that could be improved. The editing section is still too long, for example, but it's looking much better.
Review of attachment 317375 [details] [review]: the "Open item location (search and recent only)" pushes the right part and looks kinda odd with the second page (also the wording is meh, but I don't have a better idea). So LGTM!
Created attachment 317504 [details] [review] various minor improvements Here's a bunch of other minor improvements. Ctrl+X was missing, so I've added that. I've also tried to break the bigger groups down - I think this makes it easier to read. This patch is on top of https://bug759504.bugzilla-attachments.gnome.org/attachment.cgi?id=317501