After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 757692 - Programming guidelines: improve section on conditions coding style
Programming guidelines: improve section on conditions coding style
Status: RESOLVED FIXED
Product: gnome-devel-docs
Classification: Applications
Component: programming-guidelines
3.18.x
Other All
: Normal enhancement
: ---
Assigned To: GNOME Devel docs: Programming Guidelines maintainer(s)
gnome-devel-docs maintainers
Depends on:
Blocks:
 
 
Reported: 2015-11-06 16:42 UTC by Sébastien Wilmet
Modified: 2015-11-06 17:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
programming-guidelines: improve section on conditions coding style (3.16 KB, patch)
2015-11-06 16:43 UTC, Sébastien Wilmet 		committed Details | Review

Description Sébastien Wilmet 2015-11-06 16:42:40 UTC 
See the attached patch.
Comment 1 Sébastien Wilmet 2015-11-06 16:43:14 UTC 
Created attachment 315004 [details] [review]
programming-guidelines: improve section on conditions coding style

- Add one more rationale for boolean implicit comparisons
  (conversational English).
- Generalize comparisons to NULL -> comparisons to 0 values, and give
  better reasons than porting the code to C#.
- Fix the indentation of the paragraphs.
Comment 2 Sébastien Wilmet 2015-11-06 16:45:46 UTC 
git-bz didn't add the bug URL, but it's available here:
https://git.gnome.org/browse/gnome-devel-docs/log/?h=wip/swilmet/prog-guidelines
Comment 3 Philip Withnall 2015-11-06 17:03:48 UTC 
Review of attachment 315004 [details] [review]:

++
Comment 4 Sébastien Wilmet 2015-11-06 17:10:28 UTC 
Pushed:
https://git.gnome.org/browse/gnome-devel-docs/commit/?id=3b993c78a1afcca96d811f2af8bf7695f6500b23

Thanks for the quick review!