After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 757668 - gnome-shell crashes on any operation requiring password dialog
gnome-shell crashes on any operation requiring password dialog
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
3.19.x
Other Linux
: Normal critical
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 757866 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2015-11-06 07:41 UTC by tordh.bz
Modified: 2015-11-10 10:58 UTC
See Also:
GNOME target: ---
GNOME version: 3.19/3.20

Attachments
shell: Fix crash in polkit agent (1.50 KB, patch)
2015-11-06 12:25 UTC, Florian Müllner 		committed Details | Review

Description tordh.bz 2015-11-06 07:41:54 UTC 
Recently, gnome-shell has been crashing if one performs any operation needing a password such as mounting a ntfs partition. The password dialog will open and you can type in a password, and although an attempt made will work (will mount the partition) it will follow immediately with gnome-shell crashing. Also, if you cancel the dialog regardless if you enter a password, gnome-shell will immediately crash.
Comment 1 Florian Müllner 2015-11-06 12:25:32 UTC 
Created attachment 314981 [details] [review]
shell: Fix crash in polkit agent

The polkit agent does not take ownership of the request's cancellable,
so it may no longer be valid after the request finished and we need
to disconnect it before that. Before the GTask port in 8b4249ef2,
it was safe to do that when freeing the request data because requests
completed in an idle, but now we need to do it before returning the
task result.
Comment 2 Jasper St. Pierre (not reading bugmail) 2015-11-10 03:58:16 UTC 
Review of attachment 314981 [details] [review]:

OK.
Comment 3 Jasper St. Pierre (not reading bugmail) 2015-11-10 03:58:29 UTC 
*** Bug 757866 has been marked as a duplicate of this bug. ***
Comment 4 Florian Müllner 2015-11-10 10:58:11 UTC 
Attachment 314981 [details] pushed as c634718 - shell: Fix crash in polkit agent