GNOME Bugzilla – Bug 757562
Enable GtkHeaderBar for GtkDialog
Last modified: 2015-11-25 11:05:18 UTC
Created attachment 314781 [details] [review] Enable GtkHeaderBar on GtkDialog Glade supports editing GtkHeaderBars, so we can enable it for GtkDialogs. With the patch, it appears to work fine, but it probably needs more testing. When editing the headerbar we get a warning: `Gtk-WARNING **: gtk_window_set_titlebar() called on a realized window`. It would be nice to get rid of it.
I don't think editing headerbars of dialogs is a good idea for glade. GtkDialog has its own idea about managing the content of the action-area / headerbar, you are really not free to modify the headerbar of a GtkDialog in the same way that you are for a regular window.
Then we will only put a checkbox
Even though that comment about why we disabled the property pre-dates headerbar support, I believe it was quite intentional that we left it disabled when Matthias added the headerbar support. If I understand correctly, for a GtkDialog, the action area will be placed in the headerbar in an environment where dialogs have the headerbars enabled and will otherwise leave the action area in the regular place. I'm not sure if this is still the case (or if it ever was), however enabling this feature from Glade would be a bad idea which we would have a hard time backing out of later on, if Glade were to simply enable this feature, then we would be stuck with having to support Glade files "in the wild" afterwards. We should instead clarify the GtkDialog story and it's usage of the headerbar and what it does with the action area. We should also at least update that comment in gtk+.xml.in.