After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 757516 - CcInputOptions doesn't use a header bar
CcInputOptions doesn't use a header bar
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Region & Language
3.16.x
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-11-03 12:04 UTC by Debarshi Ray
Modified: 2015-11-20 17:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
region: Remove unused variable (745 bytes, patch)
2015-11-13 12:12 UTC, Debarshi Ray 		committed Details | Review
region: Turn CcInputOptions into a templatized composite widget (13.90 KB, patch)
2015-11-13 12:13 UTC, Debarshi Ray 		none Details | Review
region: Turn CcInputOptions into a templatized composite widget (14.19 KB, patch)
2015-11-13 13:17 UTC, Debarshi Ray 		committed Details | Review
region: Use header bar in the input options dialog (2.80 KB, patch)
2015-11-13 13:17 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2015-11-03 12:04:29 UTC 
CcInputOptions is one of those corners that still don't use a header bar.
Comment 1 Debarshi Ray 2015-11-13 12:12:31 UTC 
Created attachment 315397 [details] [review]
region: Remove unused variable
Comment 2 Debarshi Ray 2015-11-13 12:13:05 UTC 
Created attachment 315398 [details] [review]
region: Turn CcInputOptions into a templatized composite widget
Comment 3 Debarshi Ray 2015-11-13 13:17:22 UTC 
Created attachment 315400 [details] [review]
region: Turn CcInputOptions into a templatized composite widget

Slightly better commit message.
Comment 4 Debarshi Ray 2015-11-13 13:17:49 UTC 
Created attachment 315401 [details] [review]
region: Use header bar in the input options dialog
Comment 5 Rui Matos 2015-11-20 16:12:03 UTC 
Review of attachment 315397 [details] [review]:

ok
Comment 6 Rui Matos 2015-11-20 16:12:20 UTC 
Review of attachment 315401 [details] [review]:

++
Comment 7 Rui Matos 2015-11-20 16:12:37 UTC 
Review of attachment 315400 [details] [review]:

Looks good, thanks!
Comment 8 Debarshi Ray 2015-11-20 17:44:17 UTC 
Thanks, Rui. Pushed to master.