After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 757189 - background: Fix a few memory leaks
background: Fix a few memory leaks
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Background
3.15.x
Other All
: Normal normal
: ---
Assigned To: Debarshi Ray
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-10-27 13:37 UTC by Debarshi Ray
Modified: 2015-10-30 15:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
background: Fix a few memory leaks (2.15 KB, patch)
2015-10-27 13:39 UTC, Debarshi Ray 		committed Details | Review
background: Fix a memory leak (767 bytes, patch)
2015-10-27 15:34 UTC, Debarshi Ray 		none Details | Review
background: Fix a few memory leaks (1.32 KB, patch)
2015-10-27 16:22 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2015-10-27 13:37:26 UTC 
I discovered a few memory leaks in the Background panel while running it in valgrind.
Comment 1 Debarshi Ray 2015-10-27 13:39:16 UTC 
Created attachment 314222 [details] [review]
background: Fix a few memory leaks
Comment 2 Bastien Nocera 2015-10-27 13:40:04 UTC 
Review of attachment 314222 [details] [review]:

Looks good.
Comment 3 Debarshi Ray 2015-10-27 15:34:15 UTC 
Created attachment 314238 [details] [review]
background: Fix a memory leak
Comment 4 Debarshi Ray 2015-10-27 15:37:58 UTC 
Comment on attachment 314222 [details] [review]
background: Fix a few memory leaks

Pushed to master and all the way back to gnome-3-14.
Comment 5 Debarshi Ray 2015-10-27 16:22:22 UTC 
Created attachment 314246 [details] [review]
background: Fix a few memory leaks
Comment 6 Bastien Nocera 2015-10-27 16:25:32 UTC 
Review of attachment 314246 [details] [review]:

Sure. But if you're going to commit multiple leak fixes, in the future, fix them all at once, or split the fixes.

This patch has the exact same subject as the one before.
Comment 7 Debarshi Ray 2015-10-30 15:45:01 UTC 
(In reply to Bastien Nocera from comment #6)
> Review of attachment 314246 [details] [review] [review]:
> 
> Sure. But if you're going to commit multiple leak fixes, in the future, fix
> them all at once, or split the fixes.
> 
> This patch has the exact same subject as the one before.

Yeah, sorry about that.

Pushed to master, all the way back till gnome-3-14.