GNOME Bugzilla – Bug 757018
aggregator: Add create_new_pad() vfunc to allow subclasses to override the default behaviour
Last modified: 2015-10-23 13:33:42 UTC
See commit message
Created attachment 313939 [details] [review] aggregator: Add create_new_pad() vfunc to allow subclasses to override the default behaviour Not all aggregator subclasses will have a single pad template called sink_%u and might do something special depending on what the application requests.
Review of attachment 313939 [details] [review]: Why not override klass->create_new_pad directly?
(In reply to Thibault Saunier from comment #2) > Review of attachment 313939 [details] [review] [review]: > > Why not override klass->create_new_pad directly? And I obviously meant gstelement_class->request_new_pad
Because the implementation of GstAggregator does things that a subclass can't do and still would like to do. And we might add more things there in the future.
Review of attachment 313939 [details] [review]: Indeed, it makes sense.
commit 4eef8424b96192ea4972c549a649485c6dc4224d Author: Sebastian Dröge <sebastian@centricular.com> Date: Fri Oct 23 15:42:24 2015 +0300 aggregator: Add create_new_pad() vfunc to allow subclasses to override the default behaviour Not all aggregator subclasses will have a single pad template called sink_%u and might do something special depending on what the application requests. https://bugzilla.gnome.org/show_bug.cgi?id=757018