GNOME Bugzilla – Bug 756991
gpk-update-viewer doesn't offer to install signatures as needed
Last modified: 2020-11-23 21:21:06 UTC
If a signature needs to be installed, then gpk-update-viewer doesn't offer to install it, instead printing an error saying that the signature is not present, with no option to install it. The callback that gets called when updates are ready simply displays an error if an error code is checked, while the analogous callback in pk-task.c, for instance, checks for this condition and spawns a dialog to ask the user for permission to install a signature.
Created attachment 313894 [details] [review] Proposed patch. This fixes the issue for me, although it essentially duplicates a lot of code from pk-task.c; I'm wondering if there is a way to avoid doing that.
Thanks Mike. Heads-up: this patch probably will sit unreviewed forever unless you ping the maintainer out-of-band (hughsie on IRC).
Created attachment 319960 [details] [review] Patch to add a get_distro_upgrades wrapper to PkTask.
Created attachment 319961 [details] [review] Patch to use pk_task functions to get update lists in gpk-update-viewer. Talked with Richard on irc; decided that it probably makes sense to use pk_task functions. This patch is much simpler than my original patch but requires new API.
ping ?
Kalev, what do you think of the PackageKit change?
bugzilla.gnome.org is being replaced by gitlab.gnome.org. We are closing all older bug reports and feature requests in GNOME Bugzilla which have not seen updates for a while. If you still use gnome-packagekit and if you still see this bug / want this feature in a recent and currently supported version, then please feel free to report it at https://gitlab.gnome.org/GNOME/gnome-packagekit/-/issues/ by following the guidelines at https://wiki.gnome.org/Community/GettingInTouch/BugReportingGuidelines Thank you for creating this report and we are sorry it could not be implemented so far (volunteer workforce and time is limited).