After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 756954 - basesink: rename 'pad' arg in LOCK/COND macros
basesink: rename 'pad' arg in LOCK/COND macros
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 1.7.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-10-22 10:02 UTC by Guillaume Desmottes
Modified: 2015-10-22 15:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
basesink: rename argument of PREROLL_{COND,LOCK} macros (2.90 KB, patch)
2015-10-22 10:03 UTC, Guillaume Desmottes 		committed Details | Review

Description Guillaume Desmottes 2015-10-22 10:02:41 UTC 
Macros such as 
  #define GST_BASE_SINK_GET_PREROLL_LOCK(pad)   (&GST_BASE_SINK_CAST(pad)->preroll_lock)

are missleading as their argument is a GstBaseSink implementation and not a GstPad.
Comment 1 Guillaume Desmottes 2015-10-22 10:03:26 UTC 
Created attachment 313854 [details] [review]
basesink: rename argument of PREROLL_{COND,LOCK} macros

They take a GstBaseSink instance as argument at not a GstPad. Rename the
argument to 'obj' which is not miss leading and in line with
GST_BASE_SINK_PAD(obj).
Comment 2 Tim-Philipp Müller 2015-10-22 15:35:17 UTC 
Makes sense, thanks.

commit 66b6d355e4e876a984def6824d9def582b83359e
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date:   Thu Oct 22 12:00:42 2015 +0200

    basesink: rename argument of PREROLL_{COND,LOCK} macros
    
    They take a GstBaseSink instance as argument at not a GstPad. Rename the
    argument to 'obj' which is not miss leading and in line with
    GST_BASE_SINK_PAD(obj).
    
    https://bugzilla.gnome.org/show_bug.cgi?id=756954