After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 756931 - gstglbasemixer: negotiated logic is partly broken
gstglbasemixer: negotiated logic is partly broken
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Windows
: Normal normal
: 1.9.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-10-21 22:25 UTC by Philippe Renon
Modified: 2016-05-15 08:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
0001-gstglbasemixer-fixed-negotiated-flag-logic.patch (784 bytes, application/mbox)
2015-10-21 22:25 UTC, Philippe Renon 		Details

Description Philippe Renon 2015-10-21 22:25:39 UTC 
Created attachment 313832 [details]
0001-gstglbasemixer-fixed-negotiated-flag-logic.patch

While browsing the code I saw that the gstglbasemixer negotiated flag logic is broken.
The negotiated flag is never set to TRUE resulting in allocation queries to fail systematically.

Fix was taken from similar code found in gstglmixer.c

The fix was not really tested as the gl elements don't play to well in my environment at the moment.
Comment 1 Matthew Waters (ystreet00) 2016-05-15 08:49:12 UTC 
commit 90da62bc2526e59084bf04a9c0da7a8b05810449
Author: Matthew Waters <matthew@centricular.com>
Date:   Sat May 14 15:50:57 2016 +0300

    glbasemixer: actually attempt to propose an allocation upstream
    
    We were always failing the allocation query as a flag was never being set to
    signal a successful negotiation.  Fix by setting the required flag on a
    successful caps event from upstream.