After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 756715 - Video invisible in overview mode under Wayland session
Video invisible in overview mode under Wayland session
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: wayland
3.19.x
Other Linux
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
: 764365 771113 778040 (view as bug list)
Depends on:
Blocks: WaylandRelated
 
 
Reported: 2015-10-16 20:32 UTC by Luya Tshimbalanga
Modified: 2017-02-02 13:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screenshot of Maps (794.94 KB, image/png)
2016-06-23 09:56 UTC, Andreas Nilsson
  Details
Make all our window clones use the MetaWindowActor as source (2.88 KB, patch)
2017-02-01 18:20 UTC, Rui Matos
committed Details | Review

Description Luya Tshimbalanga 2015-10-16 20:32:36 UTC
From Red Hat Bugzilla:
Gnome Video failed to display the video in overview mode under Wayland session but visible on the workspace. Not sure if incoming release addressed the issue.

Attached video below with reproduced bug:
https://luya.fedorapeople.org/videos/Screencast%20from%2026-09-15%2005:08:33%20PM.webm

The screencast was with totem 3.16.2 but can be easily reproduced with 3.18.1
Comment 1 Luya Tshimbalanga 2015-10-16 20:33:56 UTC
Here is the relevant bug report:
https://bugzilla.redhat.com/show_bug.cgi?id=1266729
Comment 2 Andreas Nilsson 2015-10-16 20:47:53 UTC
I've seen this one too.
Comment 3 Lionel Landwerlin 2015-12-09 12:33:07 UTC
Interesting. On wayland the video has its own subsurface.
This is probably a mutter/gnome-shell issue.
Comment 4 Bastien Nocera 2015-12-09 17:36:58 UTC
(In reply to Lionel Landwerlin from comment #3)
> Interesting. On wayland the video has its own subsurface.
> This is probably a mutter/gnome-shell issue.

Yes, reassigning to mutter.
Comment 5 Andreas Nilsson 2016-06-23 09:56:02 UTC
Created attachment 330242 [details]
screenshot of Maps

Same thing happens in Maps.
Comment 6 Lionel Landwerlin 2016-06-23 09:57:22 UTC
Yes, I'm afraid anything using GL on Wayland will have that problem.
Comment 7 Jonas Ådahl 2016-06-23 10:33:17 UTC
If I remember correctly, the issue here is what clutter actor gnome-shell uses for clone-source for workspace preview, alt-tab etc, so it could possibly be a gnome-shell bug, not a mutter bug.

I suppose what we really need is a proper mutter API that gnome-shell can use so it doesn't need to have knowledge about how mutter organizes its scene graph.
Comment 8 Florian Müllner 2016-09-09 11:33:52 UTC
*** Bug 771113 has been marked as a duplicate of this bug. ***
Comment 9 Strangiato 2016-09-23 00:22:14 UTC
This bug affects Cheese too
https://www.youtube.com/watch?v=b6s01fi1aA4&feature=youtu.be
Comment 10 Sergi Granell 2016-10-08 09:25:08 UTC
Looks like a subsurface problem, like only the root surface is being showed in overview mode. I guess the solution would be to composite all the subsurfaces in overview mode.
weston-subsurfaces is also affected by this bug.
Comment 11 Christian Stadelmann 2016-10-08 10:02:57 UTC
Probably related: https://bugzilla.gnome.org/show_bug.cgi?id=772225

With gnome-maps, the map is not shown in overview mode, but the zoom buttons are.
Comment 12 smurfendrek123 2017-01-04 22:03:41 UTC
This still happens with totem 3.22.0 on fedora 25.
Comment 13 Rui Matos 2017-02-01 18:20:15 UTC
Created attachment 344731 [details] [review]
Make all our window clones use the MetaWindowActor as source

Using a MetaWindowActor's shaped texture as the source for window
clones means that if there are further MetaSurfaceActor children
(e.g. a wayland client using sub-surfaces) they don't get cloned.

This obviously wasn't an issue until wayland clients introduced the
possibility of having multiple MetaSurfaceActors under a
MetaWindowActor but there's no fundamental reason we can't clone the
toplevel actor.

WorkspaceThumbnail.WindowClone is the one class that was already using
the MetaWindowActor instead of the texture although it seems to have
been an unintended change in commit
8b99617513da1713ff88ca4abf54e6125405d31c.
Comment 14 Rui Matos 2017-02-01 18:20:53 UTC
*** Bug 778040 has been marked as a duplicate of this bug. ***
Comment 15 Rui Matos 2017-02-01 18:22:00 UTC
*** Bug 764365 has been marked as a duplicate of this bug. ***
Comment 16 Florian Müllner 2017-02-01 18:28:00 UTC
Review of attachment 344731 [details] [review]:

Clearly simpler as the patch in bug 756753, but what about the overflow issue mentioned there? (In any case, this patch looks like a good idea to me, even if additional work is required to fix some subsurface corner cases)
Comment 17 Rui Matos 2017-02-02 13:26:12 UTC
(In reply to Florian Müllner from comment #16)
> Clearly simpler as the patch in bug 756753, but what about the overflow
> issue mentioned there? (In any case, this patch looks like a good idea to
> me, even if additional work is required to fix some subsurface corner cases)

I totally missed that bug and didn't even think about the subsurface bounds problem, thanks for pointing it out. I'll push this to unbreak the this particular bug right now and leave bug 756753 to handle the bounds issue.
Comment 18 Rui Matos 2017-02-02 13:29:18 UTC
Attachment 344731 [details] pushed as 7746f1a - Make all our window clones use the MetaWindowActor as source