After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 756675 - wayland: Set the xdg_popup pointer even when not mapping
wayland: Set the xdg_popup pointer even when not mapping
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: wayland
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2015-10-16 01:55 UTC by Jonas Ådahl
Modified: 2015-10-16 03:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
wayland: Set the xdg_popup pointer even when not mapping (1.54 KB, patch)
2015-10-16 01:55 UTC, Jonas Ådahl 		committed Details | Review

Description Jonas Ådahl 2015-10-16 01:55:13 UTC 
If we immediately dismiss the popup, we still need to set the
surface->xdg_popup pointer field in order for the destructor to
properly clean up the state. Not doing this may cause a crash if the
xdg_popup resource that was immediately dismissed is destoryed after
wl_surface during client destruction.
Comment 1 Jonas Ådahl 2015-10-16 01:55:17 UTC 
Created attachment 313411 [details] [review]
wayland: Set the xdg_popup pointer even when not mapping
Comment 2 Jasper St. Pierre (not reading bugmail) 2015-10-16 03:28:23 UTC 
Review of attachment 313411 [details] [review]:

Nice catch, thanks.
Comment 3 Jonas Ådahl 2015-10-16 03:32:36 UTC 
Attachment 313411 [details] pushed as d6d377a - wayland: Set the xdg_popup pointer even when not mapping