After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 756557 - Adds "(1)" to contact names
Adds "(1)" to contact names
Status: RESOLVED FIXED
Product: gnome-maps
Classification: Applications
Component: general
3.18.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-maps-maint
gnome-maps-maint
Depends on:
Blocks:
 
 
Reported: 2015-10-14 09:06 UTC by Bastien Nocera
Modified: 2015-10-14 17:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
maps-contact-store: Do not add address type if single address (1.22 KB, patch)
2015-10-14 17:17 UTC, Jonas Danielsson
committed Details | Review

Description Bastien Nocera 2015-10-14 09:06:14 UTC
For some bizarre reason, (nearly) all my contacts have (1) appended to their names. Another one doesn't have (1) but (home).
Comment 1 Jonas Danielsson 2015-10-14 09:20:39 UTC
What does MAPS_DEBUG=1 gnome-maps say?

I am interested in a log in the code that does:
Utils.debug('Adding contact address: ' + p.name);
Comment 2 Bastien Nocera 2015-10-14 09:22:41 UTC
(In reply to Jonas Danielsson from comment #1)
> What does MAPS_DEBUG=1 gnome-maps say?
> 
> I am interested in a log in the code that does:
> Utils.debug('Adding contact address: ' + p.name);

They contain the "(1)" as well. Contacts or e-d-s bug?
Comment 3 Jonas Danielsson 2015-10-14 09:25:06 UTC
(In reply to Bastien Nocera from comment #2)
> (In reply to Jonas Danielsson from comment #1)
> > What does MAPS_DEBUG=1 gnome-maps say?
> > 
> > I am interested in a log in the code that does:
> > Utils.debug('Adding contact address: ' + p.name);
> 
> They contain the "(1)" as well. Contacts or e-d-s bug?

No, I think this one is all mine. The reason for the parenthesis is to differentiate between addresses. Since a contact can have more than one. For instance work and home.

So the (home) one I can understand. I have never seen the "(1)" tho. That might be new from e-d-s. Hmm.
Comment 4 Jonas Danielsson 2015-10-14 09:26:30 UTC
It should basically be the field name from Contacts. See: https://blogs.gnome.org/alexl/files/2011/08/robohash-contacts.png
Comment 5 Jonas Danielsson 2015-10-14 09:43:01 UTC
So maybe a fix is do not have the parenthesis if there is only one (1) address? Would that make sense to you? And then have like (Home) and (Work) sort of stuff?

But I still need to investigate where that (1) comes from.
Comment 6 Bastien Nocera 2015-10-14 10:08:49 UTC
(In reply to Jonas Danielsson from comment #5)
> So maybe a fix is do not have the parenthesis if there is only one (1)
> address? Would that make sense to you? And then have like (Home) and (Work)
> sort of stuff?

That would work for me.

> But I still need to investigate where that (1) comes from.

My contacts are in Google Contacts.
Comment 7 Jonas Danielsson 2015-10-14 17:17:08 UTC
Created attachment 313315 [details] [review]
maps-contact-store: Do not add address type if single address
Comment 8 Bastien Nocera 2015-10-14 17:19:42 UTC
Works for me!
Comment 9 Jonas Danielsson 2015-10-14 17:21:36 UTC
Attachment 313315 [details] pushed as af0e5e3 - maps-contact-store: Do not add address type if single address