After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 756529 - GDaemonFileMonitor unrefs unowned connection since 1.26.1
GDaemonFileMonitor unrefs unowned connection since 1.26.1
Status: RESOLVED DUPLICATE of bug 756153
Product: gvfs
Classification: Core
Component: client module
1.26.x
Other Linux
: Normal normal
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2015-10-13 19:19 UTC by Jan Alexander Steffens (heftig)
Modified: 2015-10-14 06:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (1.61 KB, patch)
2015-10-13 19:19 UTC, Jan Alexander Steffens (heftig) 		none Details | Review

Description Jan Alexander Steffens (heftig) 2015-10-13 19:19:59 UTC 
Created attachment 313215 [details] [review]
patch

When GDaemonFileMonitor was changed to acquire a direct daemon connection synchronously, this change missed taking a ref on the returned connection - when the connection is unreffed on monitor finalize, the thread-local connection cache now contains a dead connection.

Causes various problems:

- Nautilus is unable to restore trashed files.
- Opening a file dialog in various applications twice fails to reconnect to the daemon, logging errors.
- Firefox GTK3 crashes when opening a file dialog twice.

The attached patch takes the ref again.
Comment 1 Ondrej Holy 2015-10-14 06:19:11 UTC 
Thanks for taking the time to report this.
This particular bug has already been reported into our bug tracking system, but please feel free to report any further bugs you find.

*** This bug has been marked as a duplicate of bug 756153 ***