After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 756489 - Disabling a source can lead to a crash
Disabling a source can lead to a crash
Status: RESOLVED OBSOLETE
Product: gnome-photos
Classification: Applications
Component: general
3.16.x
Other All
: Normal normal
: ---
Assigned To: GNOME photos maintainer(s)
GNOME photos maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-10-13 09:41 UTC by Debarshi Ray
Modified: 2018-01-23 09:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Debarshi Ray 2015-10-13 09:41:14 UTC 
When a source is disabled, we don't cancel all the pending operations associated with it - creating PhotosBaseItem instances, creating thumbnails, etc.. Those operations continue with the assumption that there is a corresponding PhotosSource in PhotosSourceManager, which isn't true because we disabled the source, and this leads to a crash.

The backtrack can look like this:

+ Trace 235574

  • #0 photos_source_get_name
    at photos-source.c line 282
  • #1 photos_utils_get_provider_name
    at photos-utils.c line 651
  • #2 photos_google_item_constructed
    at photos-google-item.c line 266
  • #3 g_object_new_internal
    at gobject.c line 1814
  • #4 g_object_new_valist
    at gobject.c line 2034
  • #5 g_object_new
    at gobject.c line 1617
  • #6 photos_item_manager_create_item
    at photos-item-manager.c line 344
  • #7 photos_item_manager_add_item
    at photos-item-manager.c line 296
  • #8 photos_item_manager_item_created_executed
    at photos-item-manager.c line 61
  • #9 photos_single_item_job_emit_callback
    at photos-single-item-job.c line 63
  • #10 photos_single_item_job_cursor_next
    at photos-single-item-job.c line 90
  • #0 photos_source_get_goa_object
    at photos-source.c line 289
  • #1 photos_google_get_picasaweb_file
    at photos-google-item.c line 100
  • #2 photos_google_item_create_thumbnail
    at photos-google-item.c line 141
  • #3 photos_base_item_create_thumbnail_in_thread_func
    at photos-base-item.c line 339 






Comment 1


Umang Jain





          2018-01-02 16:23:06 UTC
        



I don't experience a crash when I disable a source(GOA) for photos. Can you just check once more Debarshi? Everything works fine on my setup with current master b42f0c4e8c

Thanks!






Comment 2


GNOME Infrastructure Team





          2018-01-23 09:49:32 UTC
        



-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-photos/issues/33.