After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 756381 - math.h include broken when compiling with VS2015
math.h include broken when compiling with VS2015
Status: RESOLVED FIXED
Product: gdk-pixbuf
Classification: Platform
Component: general
git master
Other Windows
: Normal normal
: ---
Assigned To: gdk-pixbuf-maint
gdk-pixbuf-maint
Depends on:
Blocks:
 
 
Reported: 2015-10-11 08:56 UTC by Arnav Singh
Modified: 2015-10-12 09:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Arnav Singh 2015-10-11 08:56:25 UTC 
gdk-pixbuf ships with a build/win32/math-compat/math.h file that tries to include the CRT's math.h and then add a round() implementation to it, since the math.h that ships with VS 2013 and earlier lacks this function.

I assume the file is named the same as the standard header so that the other files which include it do not need to be changed. Since this header also needs to include the CRT's math.h while itself being called math.h, it does this by including `<../include/math.h>`. This happens to work with the CRTs shipped with earlier versions of VS since their math.h was in a directory called "include", but in VS 2015 the header is in a directory named "ucrt". Thus the file cannot be included and fails compilation.

The VS 2015 math.h contains round() so this entier header is unnecessary with that SDK.
Comment 1 Fan, Chun-wei 2015-10-12 09:17:19 UTC 
Hi Arnav,

Thanks for reporting this... this should be fixed in gdk-pixbuf's master and gdk-pixbuf-2-32 branches.

With blessings, thank you!