After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 756240 - adaptivedemux: download thread should stop in case of multiple download errors
adaptivedemux: download thread should stop in case of multiple download errors
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.7.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-10-08 12:23 UTC by Florin Apostol
Modified: 2015-10-30 12:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (872 bytes, patch)
2015-10-08 12:26 UTC, Florin Apostol 		none Details | Review
proposed patch (1.13 KB, patch)
2015-10-08 23:33 UTC, Florin Apostol 		committed Details | Review

Description Florin Apostol 2015-10-08 12:23:53 UTC 
The download thread is stopped in case of EOS, NOT_LINKED or FLUSHING, but it does not stop in case of consecutive download errors. I believe it should do so.
Comment 1 Florin Apostol 2015-10-08 12:26:45 UTC 
Created attachment 312909 [details] [review]
proposed patch
Comment 2 Florin Apostol 2015-10-08 23:33:38 UTC 
Created attachment 312936 [details] [review]
proposed patch

Seems that stopping the task is not enough. We also need to change the src element state to NULL. If we don't do it, the pipeline cannot change state from PLAYING to PAUSED (because src element is locked and will return its last state which is FAILING, leading to a failure in changing pipeline state).
Comment 3 Vincent Penquerc'h 2015-10-30 12:51:12 UTC 
commit a2ffe7e9792365a998cb68f7a8330a85b7dc360b
Author: Florin Apostol <florin.apostol@oregan.net>
Date:   Fri Oct 30 12:49:20 2015 +0000

    adaptivedemux: stop task on multiple download errors
    
    On multiple download errors, we stop the download task and change the src
    element state to NULL.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=756240