After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 756101 - Remove unused libnotify dependency
Remove unused libnotify dependency
Status: RESOLVED FIXED
Product: gnome-contacts
Classification: Core
Component: general
3.18.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Contacts maintainer(s)
GNOME Contacts maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-10-06 00:04 UTC by Javier Jardón (IRC: jjardon)
Modified: 2015-10-07 03:59 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Remove unused libnotify dependency (1.29 KB, patch)
2015-10-06 00:06 UTC, Javier Jardón (IRC: jjardon)
none Details | Review
Remove unused libnotify dependency.v2 (1.66 KB, patch)
2015-10-07 00:37 UTC, Javier Jardón (IRC: jjardon)
committed Details | Review

Description Javier Jardón (IRC: jjardon) 2015-10-06 00:04:46 UTC
Patch attached
Comment 1 Javier Jardón (IRC: jjardon) 2015-10-06 00:06:08 UTC
Created attachment 312699 [details] [review]
Remove unused libnotify dependency
Comment 2 David King 2015-10-06 19:06:13 UTC
Review of attachment 312699 [details] [review]:

"Notify.init (_("Contacts"));" is called in src/main.vala.
Comment 3 Javier Jardón (IRC: jjardon) 2015-10-07 00:37:38 UTC
Created attachment 312782 [details] [review]
Remove unused libnotify dependency.v2
Comment 4 David King 2015-10-07 03:59:03 UTC
Review of attachment 312782 [details] [review]:

Pushed to master as commit 79fc31d29dcff45e9c0089eaa2b6becb1ec6f775.