After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 756068 - qtmux: fix sample memory leak
qtmux: fix sample memory leak
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 1.6.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-10-05 02:02 UTC by Vineeth
Modified: 2015-10-07 18:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
fix sample memory leak (750 bytes, patch)
2015-10-05 02:04 UTC, Vineeth
committed Details | Review

Description Vineeth 2015-10-05 02:02:37 UTC
When getting sample from taglist, the memory is not being freed resulting in memory leak.


==27959== 499 (16 direct, 483 indirect) bytes in 1 blocks are definitely lost in loss record 6,022 of 6,113
==27959==    at 0x402C17C: malloc (in /usr/lib/valgrind/vgpreload_memcheck-x86-linux.so)
==27959==    by 0x42F2BE2: g_malloc (in /lib/i386-linux-gnu/libglib-2.0.so.0.4002.0)
==27959==    by 0x4309281: g_slice_alloc (in /lib/i386-linux-gnu/libglib-2.0.so.0.4002.0)
==27959==    by 0x41312C1: gst_structure_new_id_empty_with_size (gststructure.c:145)
==27959==    by 0x41336BB: gst_structure_new_valist (gststructure.c:281)
==27959==    by 0x413371A: gst_structure_new (gststructure.c:253)
==27959==    by 0x62115E1: qtdemux_tag_add_blob (qtdemux.c:11243)
==27959==    by 0x42F62BB: g_node_children_foreach (in /lib/i386-linux-gnu/libglib-2.0.so.0.4002.0)
==27959==    by 0x62123B7: qtdemux_parse_udta (qtdemux.c:11303)
==27959==    by 0x622910E: qtdemux_parse_tree (qtdemux.c:10068)
==27959==    by 0x6232EF8: gst_qtdemux_loop_state_header (qtdemux.c:3833)
==27959==    by 0x62373A0: gst_qtdemux_loop (qtdemux.c:5233)
==27959==    by 0x413EB28: gst_task_func (gsttask.c:331)
==27959==    by 0x413FCCE: default_func (gsttaskpool.c:68)
==27959==    by 0x4314404: ??? (in /lib/i386-linux-gnu/libglib-2.0.so.0.4002.0)
==27959==    by 0x43139A9: ??? (in /lib/i386-linux-gnu/libglib-2.0.so.0.4002.0)
==27959==    by 0x43B8F6F: start_thread (pthread_create.c:312)
==27959==    by 0x44B9BED: clone (clone.S:129)
Comment 1 Vineeth 2015-10-05 02:04:20 UTC
Created attachment 312655 [details] [review]
fix sample memory leak
Comment 2 Sebastian Dröge (slomo) 2015-10-05 11:09:58 UTC
commit d7a80be3c744cff10a486e1a4e5c618e7aa85127
Author: Vineeth TM <vineeth.tm@samsung.com>
Date:   Mon Oct 5 11:03:38 2015 +0900

    qtmux: Fix sample memory leak
    
    When getting sample from taglist, the memory should be freed after
    using it.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=756068