After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 756016 - giscanner.ast: Map size_t and ssize_t to gsize and gssize, respectively
giscanner.ast: Map size_t and ssize_t to gsize and gssize, respectively
Status: RESOLVED FIXED
Product: gobject-introspection
Classification: Platform
Component: general
unspecified
Other All
: Normal minor
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-10-03 16:16 UTC by Mikhail Zabaluev
Modified: 2015-10-04 15:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
giscanner.ast: Map size_t and ssize_t to gsize and gssize, respectively (1.22 KB, patch)
2015-10-03 16:16 UTC, Mikhail Zabaluev 		accepted-commit_now Details | Review

Description Mikhail Zabaluev 2015-10-03 16:16:42 UTC 
This remapping seems better than the long int types. gsize and gssize are
legitimate fundamental types, introspected as themselves, so mapping
size_t to something else is inconsistent.
Comment 1 Mikhail Zabaluev 2015-10-03 16:16:46 UTC 
Created attachment 312606 [details] [review]
giscanner.ast: Map size_t and ssize_t to gsize and gssize, respectively

The mapping to long int types seems bogus; the code above it did the right
thing, but only for size_t.
Comment 2 Colin Walters 2015-10-03 20:00:39 UTC 
Review of attachment 312606 [details] [review]:

LGTM.  Do you have commit access?