After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 755986 - [review] support creation of MACVLANs in NetworkManager [bg/device-creation-macvlan-bgo755986]
[review] support creation of MACVLANs in NetworkManager [bg/device-creation-m...
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks: nm-review 749369
 
 
Reported: 2015-10-02 14:24 UTC by Beniamino Galvani
Modified: 2015-12-09 13:38 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Beniamino Galvani 2015-10-02 14:24:20 UTC 
This is a sub-task of bug 749369 specific for MACVLANs. The goal is to add to NM support for defining MACVLANs connections and have NM automatically create the needed software devices.
Comment 1 Beniamino Galvani 2015-10-02 15:04:01 UTC 
Pushed branch bg/device-creation-macvlan-bgo755986, please review.
Comment 2 Dan Williams 2015-10-09 20:55:13 UTC 
Looks OK to me from a higher level; I didn't jump down to checking memory allocations/frees and stuff like that.  But the API bits seem fine to me.
Comment 3 Beniamino Galvani 2015-12-04 21:05:45 UTC 
Cleaned up and rebased on current master.
Comment 4 Dan Williams 2015-12-04 22:11:14 UTC 
LGTM