After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 755898 - [PATCH] settings: add get/set uint64
[PATCH] settings: add get/set uint64
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gsettings
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: Allison Karlitskaya (desrt)
gtkdev
Depends on:
Blocks:
 
 
Reported: 2015-09-30 19:32 UTC by Marc-Antoine Perennou
Modified: 2016-04-28 15:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
add uint64 accessors (4.17 KB, patch)
2015-09-30 19:33 UTC, Marc-Antoine Perennou 		none Details | Review
add {,u}int64 accessors (7.36 KB, patch)
2015-10-01 15:43 UTC, Marc-Antoine Perennou 		none Details | Review
add {,u}int64 accessors (7.46 KB, patch)
2016-02-29 19:03 UTC, Marc-Antoine Perennou 		committed Details | Review

Description Marc-Antoine Perennou 2015-09-30 19:32:50 UTC 
Currently, there are convenience accessors for a lot of types but not uint64 yet
Comment 1 Marc-Antoine Perennou 2015-09-30 19:33:47 UTC 
Created attachment 312447 [details] [review]
add uint64 accessors
Comment 2 Allison Karlitskaya (desrt) 2015-09-30 20:07:40 UTC 
Review of attachment 312447 [details] [review]:

Please correct the trivial docs typo below.

Please add the new APIs to the gio-sections.txt file.

Why no _int64 variants as well?

::: gio/gsettings.c
@@ +1945,3 @@
+ * having a uint64 type in the schema for @settings.
+ *
+ * Returns: a 64-bits unsigned integer

"64-bit" (no 's')
Comment 3 Marc-Antoine Perennou 2015-10-01 15:43:00 UTC 
Created attachment 312500 [details] [review]
add {,u}int64 accessors
Comment 4 Allison Karlitskaya (desrt) 2016-02-29 18:59:16 UTC 
Review of attachment 312500 [details] [review]:

::: gio/gsettings.c
@@ +2006,3 @@
+                       const gchar *key)
+{
+  g_autoptr (GVariant) value;

We can't use this in GLib...
Comment 5 Marc-Antoine Perennou 2016-02-29 19:03:42 UTC 
Created attachment 322692 [details] [review]
add {,u}int64 accessors
Comment 6 Allison Karlitskaya (desrt) 2016-03-09 18:19:42 UTC 
This looks good but it's a bit late for this cycle.  Let's add it after we branch.
Comment 7 Allison Karlitskaya (desrt) 2016-03-09 18:19:51 UTC 
Review of attachment 322692 [details] [review]:

.
Comment 8 Marc-Antoine Perennou 2016-04-28 15:29:35 UTC 
Review of attachment 322692 [details] [review]:

pushed as 5cea1c861def0251a10cd4de01908aaf3276c72d