After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 755861 - uri-asset: reallocate a passed GError pointer.
uri-asset: reallocate a passed GError pointer.
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-editing-services
git master
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-09-30 08:51 UTC by Justin Kim
Modified: 2015-10-01 03:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
uri-asset error (1.35 KB, patch)
2015-09-30 08:51 UTC, Justin Kim 		needs-work Details | Review

Description Justin Kim 2015-09-30 08:51:36 UTC 
In discoverer_discovered_cb, a passed pointer for GError is reallocated so it causes leakage, and normally that's not a good idea.
Comment 1 Justin Kim 2015-09-30 08:51:53 UTC 
Created attachment 312408 [details] [review]
uri-asset error
Comment 2 Thibault Saunier 2015-09-30 10:25:10 UTC 
Breaks make check:

====================================================================
   GStreamer Editing Services 1.7.0.1: tests/check/test-suite.log
====================================================================

# TOTAL: 19
# PASS:  16
# SKIP:  0
# XFAIL: 0
# FAIL:  3
# XPASS: 0
# ERROR: 0

.. contents:: :depth: 2

FAIL: ges/uriclip
=================

Running suite(s): ges-filesource


Unexpected critical/warning: g_error_free: assertion 'error != NULL' failed
66%: Checks: 3, Failures: 1, Errors: 0
gstcheck.c:79:F:filesource:test_filesource_basic:0: Unexpected critical/warning: g_error_free: assertion 'error != NULL' failed
FAIL ges/uriclip (exit status: 1)

FAIL: ges/timelineedition
=========================

Running suite(s): ges-timeline-edition


Unexpected critical/warning: g_error_free: assertion 'error != NULL' failed
85%: Checks: 7, Failures: 1, Errors: 0
gstcheck.c:79:F:timeline-edition:test_simple_triming:0: Unexpected critical/warning: g_error_free: assertion 'error != NULL' failed
FAIL ges/timelineedition (exit status: 1)

FAIL: ges/project
=================

Running suite(s): ges-project


Unexpected critical/warning: g_error_free: assertion 'error != NULL' failed


Unexpected critical/warning: g_error_free: assertion 'error != NULL' failed
0:00:00.224563359  1521 0x559a89aceca0 ERROR           GST_PIPELINE grammar.y:691:priv_gst_parse_yyparse: no element "nowaythiselementexists"
50%: Checks: 6, Failures: 3, Errors: 0
ges/project.c:190:F:project:test_project_load_xges:0: Assertion 'GST_IS_DISCOVERER_INFO (info)' failed
gstcheck.c:79:F:project:test_project_add_properties:0: Unexpected critical/warning: g_error_free: assertion 'error != NULL' failed
gstcheck.c:79:F:project:test_project_auto_transition:0: Unexpected critical/warning: g_error_free: assertion 'error != NULL' failed
FAIL ges/project (exit status: 3)
Comment 3 Thibault Saunier 2015-09-30 10:25:35 UTC 
Review of attachment 312408 [details] [review]:

See previous comment
Comment 4 Justin Kim 2015-10-01 03:17:53 UTC 
I moved this patch to https://phabricator.freedesktop.org/D302