After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 755775 - Report progress when copying and moving
Report progress when copying and moving
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: google backend
unspecified
Other All
: Normal normal
: ---
Assigned To: Debarshi Ray
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2015-09-29 08:55 UTC by Ondrej Holy
Modified: 2015-09-30 07:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
google: Report progress when copying and moving (2.03 KB, patch)
2015-09-29 08:56 UTC, Ondrej Holy 		committed Details | Review

Description Ondrej Holy 2015-09-29 08:55:24 UTC 
Progress isn't reported currently. However it is guaranteed that the progress callback will be called at least after all data has been transferred according the GIO documentation. Nautilus shows some weird progress info when moving and copying consequently.
Comment 1 Ondrej Holy 2015-09-29 08:56:50 UTC 
Created attachment 312347 [details] [review]
google: Report progress when copying and moving

Emit progress callback with total size to fix this issue.
Comment 2 Debarshi Ray 2015-09-29 15:25:20 UTC 
Review of attachment 312347 [details] [review]:

Thanks for fixing this Ondrej. I had noticed that nautilus 3.17.x would continue to show the pie-chart button with empty progress indicators, and I had hand waved it as some nautilus bug. It never struck me that this would be the cause of it.

The patch looks good to me, and, as far as I can tell, works as expected.

I am not a gvfs reviewer, hence not setting 'a-c-n'.
Comment 3 Ondrej Holy 2015-09-30 07:03:21 UTC 
Review of attachment 312347 [details] [review]:

Thanks for the review. Pushed as commit 3a70ae6.
Comment 4 Ondrej Holy 2015-09-30 07:28:06 UTC 
Just a notice that this code has to be modified once file size reporting will be fixed, because currently zeros are reported for shared files and consequently Nautilus is showing wrong speed/time estimations for them...