After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 755739 - tracker: add systemd user services corresponding to the D-Bus session services
tracker: add systemd user services corresponding to the D-Bus session services
Status: RESOLVED FIXED
Product: tracker
Classification: Core
Component: General
1.4.x
Other Linux
: Normal enhancement
: ---
Assigned To: tracker-general
tracker-general
Depends on:
Blocks:
 
 
Reported: 2015-09-28 14:11 UTC by Simon McVittie
Modified: 2016-05-16 10:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add systemd user services corresponding to D-Bus session services (17.86 KB, patch)
2015-09-28 14:11 UTC, Simon McVittie
committed Details | Review

Description Simon McVittie 2015-09-28 14:11:21 UTC
Created attachment 312307 [details] [review]
Add systemd user services corresponding to D-Bus session services

Adding systemd user services corresponding to D-Bus session services allows systemd to put the services in correct cgroups, instead of being treated as part of dbus.service. This patch does that, and makes use of it to get automatic restart for all services.

The one exception is the email miner, which does not actually have anything to start, so its D-Bus service file won't work anyway. I assume it's there because Tracker uses it for miner discovery internally; I would prefer it if Tracker could avoid installing incomplete D-Bus service files into dbus-daemon's search path.

Restart the services on failure, but do not after SIGKILL, because that's what `tracker daemon --kill` (formerly `tracker-control --kill`) does. systemd already treats SIGTERM as a graceful exit which is not considered to be a failure.

Loosely based on a patch by Alban Crequy, which only applied this to tracker-store and tracker-miner-fs, and did not have the special handling for SIGKILL.
Comment 1 Carlos Garnacho 2016-05-13 23:06:52 UTC
Comment on attachment 312307 [details] [review]
Add systemd user services corresponding to D-Bus session services

Thanks for the patch :), looks fine to push to master.
Comment 2 Simon McVittie 2016-05-16 10:13:23 UTC
Comment on attachment 312307 [details] [review]
Add systemd user services corresponding to D-Bus session services

Committed as 44eed82 for (presumably) 1.9.0, thanks.
Comment 3 Carlos Garnacho 2016-05-16 10:49:06 UTC
Yes, 1.9 is already branched. Thanks :)