After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 755521 - Unable to launch gnome-maps
Unable to launch gnome-maps
Status: RESOLVED FIXED
Product: gnome-maps
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-maps-maint
gnome-maps-maint
Depends on:
Blocks:
 
 
Reported: 2015-09-24 10:01 UTC by Andreas Nilsson
Modified: 2015-09-25 16:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
application: Fix return value for 'handle-local-options' (784 bytes, patch)
2015-09-25 05:17 UTC, Jonas Danielsson
none Details | Review
application: Fix return value for 'handle-local-options' (1.19 KB, patch)
2015-09-25 16:50 UTC, Jonas Danielsson
committed Details | Review

Description Andreas Nilsson 2015-09-24 10:01:04 UTC
I've tried this on two recent Fedora 23 systems and one GNOME-Continuous system and Maps won't launch, not even through the terminal.
No idea what could be up.
Comment 1 Jonas Danielsson 2015-09-24 10:35:12 UTC
No output on the terminal at all?
Comment 2 Andreas Nilsson 2015-09-24 10:57:28 UTC
Nope :(
Can I do some kind of verbose or debug when launching it?
Comment 3 Jonas Danielsson 2015-09-24 11:01:36 UTC
MAPS_DEBUG=1 gnome-maps

Also what does:

$ which gnome-maps

tell you?
Comment 4 Andreas Nilsson 2015-09-24 11:09:22 UTC
$ which gnome-maps
/usr/bin/gnome-maps
Comment 5 Andreas Nilsson 2015-09-24 11:22:55 UTC
http://paste.fedoraproject.org/270972/
Comment 6 Matthias Clasen 2015-09-24 11:45:20 UTC
looks like confusion about org.gnome.Maps.gschema.xml vs org.gnome.maps.gschema.xml
Comment 7 Jonas Danielsson 2015-09-24 12:19:19 UTC
Thanks!

Exactly where do you see this confusion?

All the .po files have the file wrong:
$ git grep org.gnome.maps
data/org.gnome.Maps.gschema.xml:  <schema id="org.gnome.Maps" path="/org/gnome/maps/">
po/af.po:#: ../data/org.gnome.maps.gschema.xml.in.h:1
po/af.po:#: ../data/org.gnome.maps.gschema.xml.in.h:2


Other than that the only diff I have is:
$ git grep org.gnome.maps | grep -v po                                                                                                                        ~/sandbox/gnome-maps
data/org.gnome.Maps.gschema.xml:  <schema id="org.gnome.Maps" path="/org/gnome/maps/">

find . -name org.gnome.Maps\*                                                                                                                               ~/sandbox/gnome-maps
./src/org.gnome.Maps.src.gresource.xml
./src/org.gnome.Maps.in
./data/org.gnome.Maps.desktop.in
./data/org.gnome.Maps.appdata.xml.in
./data/org.gnome.Maps.gschema.xml
./data/org.gnome.Maps.data.gresource.xml
./data/org.gnome.Maps.service.in

find . -name org.gnome.maps\* 
[empty]
Comment 8 Matthias Clasen 2015-09-24 14:33:02 UTC
diff --git a/data/Makefile.am b/data/Makefile.am
index 6c1f31c..53c2315 100644
--- a/data/Makefile.am
+++ b/data/Makefile.am
@@ -21,7 +21,7 @@ apps_DATA = org.gnome.Maps.desktop
 
 @INTLTOOL_XML_RULE@
 
-gsettings_SCHEMAS = org.gnome.Maps.gschema.xml
+gsettings_SCHEMAS = org.gnome.maps.gschema.xml
 @GSETTINGS_RULES@
 
 appdatadir = $(datadir)/appdata
Comment 9 Jonas Danielsson 2015-09-24 15:43:43 UTC
I still do not really get it... what is the confusion. All my files are called or.gnome.Maps.gschema.xml.

If I just do this as a patch I will get a build error. What am I missing?
Comment 10 mpiazza 2015-09-24 21:16:34 UTC
I bisected it.

This is my bisect log:
git bisect start
# bad: [b0f2c86b6650b5becf66ee1bd1b0b8688c3e69da] Updated Serbian Latin translation
git bisect bad b0f2c86b6650b5becf66ee1bd1b0b8688c3e69da
# good: [c5b36478e7ef891b844978cd31bb2b5770cadfbc] Release 3.17.90.1
git bisect good c5b36478e7ef891b844978cd31bb2b5770cadfbc
# bad: [d6209d8994a7f2368ce2e1b77518438b0656a0c0] Updated Polish translation
git bisect bad d6209d8994a7f2368ce2e1b77518438b0656a0c0
# good: [889cf10a2b24594d768364a13d23ba80e37887a8] Updated Hungarian translation
git bisect good 889cf10a2b24594d768364a13d23ba80e37887a8
# good: [873133f929aec17a429a1002b7d356e1c0de176f] Updated Norwegian bokmål translation.
git bisect good 873133f929aec17a429a1002b7d356e1c0de176f
# good: [6f262fe4d1494c787a9e5e90dcc14bd2660895d1] Updated Slovenian translation
git bisect good 6f262fe4d1494c787a9e5e90dcc14bd2660895d1
# good: [30a9721f208b84721941b2880cd31912a4256a6d] Add file tile source
git bisect good 30a9721f208b84721941b2880cd31912a4256a6d
# bad: [0ba1f101dbca64f0d95b2612ac562973654a5329] Add --local switch to open local tile directory
git bisect bad 0ba1f101dbca64f0d95b2612ac562973654a5329
# first bad commit: [0ba1f101dbca64f0d95b2612ac562973654a5329] Add --local switch to open local tile directory

Hope it helps.
Comment 11 Jonas Danielsson 2015-09-25 05:17:57 UTC
Created attachment 312109 [details] [review]
application: Fix return value for 'handle-local-options'

Thank you!

Could you try this patch? And see if it fixes your issue?
Comment 12 Matthias Clasen 2015-09-25 11:38:02 UTC
quite possible that maps vs Maps was a red herring, just ignore it.
Comment 13 mpiazza 2015-09-25 15:17:49 UTC
Great!

The patch attached solved the problem.
Comment 14 Jonas Danielsson 2015-09-25 16:50:04 UTC
Created attachment 312158 [details] [review]
application: Fix return value for 'handle-local-options'

We need to return -1  in the handler to signal that default
processing should resume.
Comment 15 Jonas Danielsson 2015-09-25 16:57:19 UTC
Review of attachment 312158 [details] [review]:

Pushed fix!

Thanks a lot for bisect!