After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 755087 - validate: launcher: Print error when media-info and media files not present in folder
validate: launcher: Print error when media-info and media files not present i...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-devtools
unspecified
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-09-16 01:31 UTC by Vineeth
Modified: 2015-11-11 09:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
print error when media-info files are not present (1.48 KB, patch)
2015-09-16 01:32 UTC, Vineeth 		none Details | Review
print error when media-info and media files are not present (2.27 KB, patch)
2015-09-16 03:42 UTC, Vineeth 		none Details | Review
print error when media-info and media files are not present (2.25 KB, patch)
2015-10-05 04:40 UTC, Vineeth 		committed Details | Review

Description Vineeth 2015-09-16 01:31:21 UTC 
When there are no media-info files present and --generate-media-info option is not given, then it just fails without printing error. Printing an error stating, use --generate-media-info if there are no media info files.
Comment 1 Vineeth 2015-09-16 01:32:56 UTC 
Created attachment 311426 [details] [review]
print error when media-info files are not present
Comment 2 Vineeth 2015-09-16 03:42:37 UTC 
Created attachment 311428 [details] [review]
print error when media-info and media files are not present
Comment 3 Thibault Saunier 2015-10-02 15:19:28 UTC 
Review of attachment 311428 [details] [review]:

::: validate/launcher/apps/gstvalidate.py
@@ +646,3 @@
                 return True
             elif not self.options.generate_info and not self.options.update_media_info and not self.options.validate_uris:
+                printc("%s not present. Use --generate-media-info" % media_info, Colors.FAIL)

This might not be an error and what the user expect, please use self.info() instead (if it does not existe make sure we descend from Loggable.
Comment 4 Vineeth 2015-10-05 04:40:16 UTC 
Created attachment 312661 [details] [review]
print error when media-info and media files are not present

Did not understand what you mean by
"if it does not existe make sure we descend from Loggable"

Changed from printc to self.info
Please check if any other changes needs to be done.
Comment 5 Vineeth 2015-11-11 00:33:04 UTC 
ping :)
Comment 6 Thibault Saunier 2015-11-11 09:05:17 UTC 
Review of attachment 312661 [details] [review]:

OK