After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 754944 - Remove unnecessary callbacks from GtkClutterEmbed
Remove unnecessary callbacks from GtkClutterEmbed
Status: RESOLVED FIXED
Product: clutter-gtk
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: clutter-gtk maintainer(s)
clutter-gtk maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-09-13 07:38 UTC by Lionel Landwerlin
Modified: 2015-09-15 10:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
embed: remove map/unmap vfunc (2.51 KB, patch)
2015-09-13 07:38 UTC, Lionel Landwerlin 		none Details | Review
embed: remove map/unmap vfunc (2.08 KB, patch)
2015-09-15 00:34 UTC, Lionel Landwerlin 		committed Details | Review

Description Lionel Landwerlin 2015-09-13 07:38:01 UTC 
It turns out we don't need the map/unmap vfunc anymore :)
Less code \o/
Comment 1 Lionel Landwerlin 2015-09-13 07:38:05 UTC 
Created attachment 311226 [details] [review]
embed: remove map/unmap vfunc

Something I didn't quite realize is that the map vfunc is called :

"when widget is going to be mapped"

This is unnecessary now that we want to realize the stage only once
the embedding widget is actually visible. We just need to listen to
the "map-event" signal.
Comment 2 Emmanuele Bassi (:ebassi) 2015-09-14 12:03:28 UTC 
Review of attachment 311226 [details] [review]:

Okay.

::: clutter-gtk/gtk-clutter-embed.c
@@ +523,3 @@
                         | GDK_TOUCH_MASK
+                        | GDK_SMOOTH_SCROLL_MASK
+                        | GDK_STRUCTURE_MASK;

This means we won't be receiving Configure events; is it intended? If so, I'd move it to a separate commit.
Comment 3 Lionel Landwerlin 2015-09-15 00:34:53 UTC 
Created attachment 311317 [details] [review]
embed: remove map/unmap vfunc

Something I didn't quite realize is that the map vfunc is called :

"when widget is going to be mapped"

This is unnecessary now that we want to realize the stage only once
the embedding widget is actually visible. We just need to listen to
the "map-event" signal.
Comment 4 Lionel Landwerlin 2015-09-15 00:35:43 UTC 
Review of attachment 311226 [details] [review]:

::: clutter-gtk/gtk-clutter-embed.c
@@ +523,3 @@
                         | GDK_TOUCH_MASK
+                        | GDK_SMOOTH_SCROLL_MASK
+                        | GDK_STRUCTURE_MASK;

Thanks, this shouldn't have been there. Splitting out.
Comment 5 Emmanuele Bassi (:ebassi) 2015-09-15 10:36:40 UTC 
Review of attachment 311317 [details] [review]:

Looks good.
Comment 6 Lionel Landwerlin 2015-09-15 10:51:52 UTC 
Review of attachment 311317 [details] [review]:

Pushed to master.