After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 754916 - UI messages from roomStack.js are not translatable
UI messages from roomStack.js are not translatable
Status: RESOLVED FIXED
Product: polari
Classification: Applications
Component: general
3.17.x
Other All
: Normal normal
: ---
Assigned To: Polari maintainers
Polari maintainers
Depends on:
Blocks:
 
 
Reported: 2015-09-12 07:43 UTC by Jiro Matsuzawa
Modified: 2015-09-16 17:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Image of untranslatable messages (11.45 KB, image/png)
2015-09-12 07:43 UTC, Jiro Matsuzawa 		  Details
Add src/roomStack.js to POTFILES.in (579 bytes, patch)
2015-09-12 07:50 UTC, Jiro Matsuzawa 		committed Details | Review
roomStack: Mark strings as translatable (1.68 KB, patch)
2015-09-12 07:52 UTC, Jiro Matsuzawa 		committed Details | Review
roomStack: Mark app name "Polari" as translatable (999 bytes, patch)
2015-09-12 08:17 UTC, Jiro Matsuzawa 		committed Details | Review

Description Jiro Matsuzawa 2015-09-12 07:43:17 UTC 
Created attachment 311198 [details]
Image of untranslatable messages

UI messages from roomStack.js are not translatable.
We need to fix the following two problems with this bug:
  1. POTFILES.in does not have roomStack.js.
  2. Some messages are not wrapped with gettext in roomStack.js. (e.g. "Begin chatting by adding a new connection.")

Patches are coming. They doesn't break the string freeze, because the messages already exist.
Comment 1 Jiro Matsuzawa 2015-09-12 07:50:11 UTC 
Created attachment 311199 [details] [review]
Add src/roomStack.js to POTFILES.in
Comment 2 Jiro Matsuzawa 2015-09-12 07:52:08 UTC 
Created attachment 311200 [details] [review]
roomStack: Mark strings as translatable
Comment 3 Jiro Matsuzawa 2015-09-12 08:17:53 UTC 
Created attachment 311201 [details] [review]
roomStack: Mark app name "Polari" as translatable

And additional patch. However, I'm not sure if you'd like this 3rd patch for 3.18. It will break the string freeze (the previous two patches don't). But it makes sense, because some languages (i.e. eo, ko, ne, pa, sr, te, uk) translate the app name "Polari" into their own word.
Comment 4 Florian Müllner 2015-09-16 17:07:56 UTC 
(In reply to Jiro Matsuzawa from comment #3)
> I'm not sure if you'd like this 3rd patch for 3.18. It will break the string
> freeze

I don't think so - the string "Polari" is already marked for translation in the .desktop file, so the change should be fine.

Also, provided that we *are* already localizing the name in the context of the .desktop file, it makes sense to be consistent elsewhere and apply the patch.
Comment 5 Florian Müllner 2015-09-16 17:20:55 UTC 
Attachment 311199 [details] pushed as 256069f - Add src/roomStack.js to POTFILES.in
Attachment 311200 [details] pushed as bdd58c5 - roomStack: Mark strings as translatable
Attachment 311201 [details] pushed as 6f5e06d - roomStack: Mark app name "Polari" as translatable