After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 754912 - Regression: Caret navigation no longer works
Regression: Caret navigation no longer works
Status: RESOLVED FIXED
Product: yelp
Classification: Applications
Component: General
unspecified
Other Linux
: Normal major
: ---
Assigned To: Yelp maintainers
Yelp maintainers
Depends on:
Blocks:
 
 
Reported: 2015-09-11 23:46 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2015-09-21 23:08 UTC
See Also:
GNOME target: 3.18
GNOME version: ---

Attachments
yelp-view: Do not initialize global settings in class_init (2.58 KB, patch)
2015-09-21 16:47 UTC, Carlos Garcia Campos 		committed Details | Review

Description Joanmarie Diggs (IRC: joanie) 2015-09-11 23:46:19 UTC 
Somewhere between 3.16.0 and now, caret navigation broke. (I tried git bisect, but had too many build failures. Sorry!)

One of the main ways Orca users read help content is by using the native caret navigation provided by Yelp/WebKitGtk. As the caret moves in response to the user arrowing, Orca presents the text at the new location. This regression makes Yelp pretty inaccessible for users who are blind.
Comment 1 Carlos Garcia Campos 2015-09-21 16:14:52 UTC 
It's weird, for some reason the settings object passed to the view at construction is not set. webkit_web_view_set_settings is not called before constructed, so a new WebKitSettings object is created for the view. We do da same in ephy, we have a view object derived from WebKitWebView, and we pass the settings object to g_object_new, so I don't understand why it doesn't work here.
Comment 2 Carlos Garcia Campos 2015-09-21 16:30:43 UTC 
Ok, I think I know what's going on, global settings are created in class_init, so when calling to g_object_new we are actually passing NULL. I'll try a different approach
Comment 3 Carlos Garcia Campos 2015-09-21 16:47:10 UTC 
Created attachment 311777 [details] [review]
yelp-view: Do not initialize global settings in class_init
Comment 4 Shaun McCance 2015-09-21 17:12:41 UTC 
Works for me. Let's ask for a code freeze break to get this into 3.18.0.
Comment 5 David King 2015-09-21 17:14:55 UTC 
Review of attachment 311777 [details] [review]:

Looks fine to me.
Comment 6 David King 2015-09-21 23:08:10 UTC 
Review of attachment 311777 [details] [review]:

Shaun got approval from the release team and pushed the patch into 3.18.0.