GNOME Bugzilla – Bug 754811
spotify: implement Spotify plugin
Last modified: 2017-12-26 22:56:22 UTC
This is an initial implementation of the Spotify plugin, which just retrieves audio coverart with the Spotify public API. A more sophisticated and featureful version will come after this is settled and GNOME 3.18 is released.
Created attachment 311032 [details] [review] spotify: implement Spotify plugin
You'll have to give me an example query, because I can't get it to find any covers.
Created attachment 311048 [details] [review] lua-factory: Add Spotify cover source
You'll need to make changes to tests/lastfm-albumart to test through the spotify plugin rather than the (now broken) last.fm plugin.
Comment on attachment 311032 [details] [review] spotify: implement Spotify plugin Not adding a big C plugin for that.
(In reply to Bastien Nocera from comment #5) > Comment on attachment 311032 [details] [review] [review] > spotify: implement Spotify plugin > > Not adding a big C plugin for that. Should I stop working on that entirely?
(In reply to Georges Basile Stavracas Neto from comment #6) > (In reply to Bastien Nocera from comment #5) > > Comment on attachment 311032 [details] [review] [review] [review] > > spotify: implement Spotify plugin > > > > Not adding a big C plugin for that. > > Should I stop working on that entirely? There's a lua plugin now. You'll need to write the tests for that plugin (the local-metadata plugin is an example of using lua sources in tests, and lastfm-albumart an example of cover lookups). Given the clarity and the lack of boilerplate in the lua code, I really prefer that to the amount of C code and build infrastructure. Here's a start of a patch for the lastfm-albumart tests to use the new spotify cover plugin: http://paste.fedoraproject.org/265618/18894551
Created attachment 311091 [details] [review] lua-factory: Add Spotify cover source
Attachment 311091 [details] pushed as 03ee614 - lua-factory: Add Spotify cover source
Spotify needs authorization now. Any way to provide header Auth token? I check and with a correct token it works
@Alberto: Please create new tasks for new requests / problems. This task has been closed for two years. Thanks.
Sure, sorry for that