After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 754802 - do not show Labels on sidebar if no label is present
do not show Labels on sidebar if no label is present
Status: RESOLVED FIXED
Product: geary
Classification: Other
Component: ux
0.10.x
Other Linux
: Normal minor
: 0.12.1
Assigned To: Geary Maintainers
Geary Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-09-09 20:12 UTC by Federico Bruni
Modified: 2018-01-27 06:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch proposal v1 (4.19 KB, patch)
2017-03-02 11:01 UTC, Gautier Pelloux-Prayer 		committed Details | Review

Description Federico Bruni 2015-09-09 20:12:07 UTC 
I hope that I'm not nitpicking too much :)

It's really a minor issue but it would be sensible to not list Labels on the side bar if no label has been created yet. If you click on it nothing happens, because it's just a "container" and not a folder.
Comment 1 Gautier Pelloux-Prayer 2017-03-02 11:01:34 UTC 
Created attachment 347044 [details] [review]
patch proposal v1

Here is an attempt to hide it. Any test/review's welcome :).
Comment 2 Federico Bruni 2017-12-21 21:40:57 UTC 
Hey Gautier, I must have missed your patch!
I've just tested it and it works great!

I have only a minor issue, which does not depend on your patch.
Geary cannot detect the Spam and Archive special folders of my dovecot account, while it detects immediately the other special folders. So I had to set them manually in geary.ini file.
As a result, when I launch Geary I always see *for a few seconds* the Labels folder containing the Archive and Spam folders. Then I guess that Geary reads the geary.ini file and show them as special folders, so the Labels becomes empty. As soon as it's empty, thanks to your patch, the Labels disappears from sidebar.
Comment 3 Michael Gratton 2018-01-09 09:30:07 UTC 
Review of attachment 347044 [details] [review]:

I was prevaricating landing this because I was hoping to land Bug 730712 instead in 0.13. But that's in danger of slipping to 0.14, and this would be good to apply to 0.12 as well, so it's been pushed to master as commit ff95fb8. Will merge to stable once it's been tested there a bit. Thanks Gautier!
Comment 4 Michael Gratton 2018-01-27 06:08:34 UTC 
Pushed to geary-0.12 as commit 7fbb67d.