After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 754666 - decklinkvideosink: Consider pipeline latency when scheduling frames
decklinkvideosink: Consider pipeline latency when scheduling frames
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
unspecified
Other All
: Normal normal
: 1.5.91
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-09-07 10:46 UTC by Sebastian Dröge (slomo)
Modified: 2015-09-09 14:00 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
decklinkvideosink: Consider pipeline latency when scheduling frames (1.12 KB, patch)
2015-09-07 10:46 UTC, Sebastian Dröge (slomo)
none Details | Review
decklinkvideosink: Consider pipeline latency, render delay and ts offset when scheduling frames (1.96 KB, patch)
2015-09-07 15:16 UTC, Sebastian Dröge (slomo)
committed Details | Review

Description Sebastian Dröge (slomo) 2015-09-07 10:46:31 UTC
See commit message
Comment 1 Sebastian Dröge (slomo) 2015-09-07 10:46:36 UTC
Created attachment 310795 [details] [review]
decklinkvideosink: Consider pipeline latency when scheduling frames

Without this, we will schedule all frames too late in live pipelines.
Comment 2 Sebastian Dröge (slomo) 2015-09-07 15:16:38 UTC
Created attachment 310830 [details] [review]
decklinkvideosink: Consider pipeline latency, render delay and ts offset when scheduling frames

Without this, we will schedule all frames too late in live pipelines.
Comment 3 Tim-Philipp Müller 2015-09-09 13:02:48 UTC
Bit unfortunate that we are duplicating calculations from basesink here, perhaps we should add a ::schedule() vfunc or so that's like prepare but with the time to schedule it at.
Comment 4 Sebastian Dröge (slomo) 2015-09-09 14:00:04 UTC
That would indeed be a useful addition to basesink :)


commit a6744a915b22c0cd602ba6cdcea1a48babf6030b
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Mon Sep 7 13:36:19 2015 +0300

    decklinkvideosink: Consider pipeline latency, render delay and ts offset when scheduling frames
    
    Without this, we will schedule all frames too late in live pipelines.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=754666