Created attachment 310590 [details] [review]
loginDialog: Limit user list to the available height

We currently will always allocate the user list's preferred size, so it
will grow indefinitely and never scroll; limit the height instead to
get the desired scrolling behavior when necessary.

Review of attachment 310590 [details] [review]:

seems right to me.

::: js/gdm/loginDialog.js
@@ +537,3 @@
 
+        natHeight = Math.min(natHeight, dialogBox.y2 - dialogBox.y1);
+

should probably do natWidth above it too, for symmetry, even though it's less likely to be a problem practically speaking.

Attachment 310590 [details] pushed as 09dbe17 - loginDialog: Limit user list to the available height

(In reply to Ray Strode [halfline] from comment #2)
> should probably do natWidth above it too, for symmetry, even though it's
> less likely to be a problem practically speaking.

Sure, though we don't scroll horizontally, so we'll likely run into some underallocation issues should we ever hit this case (but the symmetry argument still makes sense to me)