After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 754524 - keyboard navigation broken when adding a new input source (keyboard layout)
keyboard navigation broken when adding a new input source (keyboard layout)
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Region & Language
3.17.x
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-09-03 13:23 UTC by Christian Stadelmann
Modified: 2015-09-07 14:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
region: Fix the input chooser add button sensitiveness logic (1.42 KB, patch)
2015-09-03 17:30 UTC, Rui Matos 		committed Details | Review

Description Christian Stadelmann 2015-09-03 13:23:31 UTC 
Steps to reproduce:
1. open gnome-control-center, go to "Region & Language"
2. below "Input Sources", press the "add" button
3. (first list) choose any language by keyboard (first level)
4. (second list) try to choose a keyboard layout by using the arrow keys

What happens:
UI goes back to language selection, unable to choose a keyboard layout by using arrow, tab, space and enter keys.

What should happen:
The second list (keyboard layout) should be keyboard-navigable as is the first one.

Tested with:
control-center-3.16.3-1.fc22.x86_64
control-center-3.17.90-1.fc23.x86_64
Comment 1 Rui Matos 2015-09-03 17:30:39 UTC 
Created attachment 310611 [details] [review]
region: Fix the input chooser add button sensitiveness logic

Going back when the back row just gets selected breaks keyboard
navigation. This behavior got introduced by mistake in commit
f28e06a4. Instead, let's just do the add button sensitiveness logic
here. The back row still works when activated.
Comment 2 Bastien Nocera 2015-09-07 14:51:00 UTC 
Review of attachment 310611 [details] [review]:

Sure.
Comment 3 Rui Matos 2015-09-07 14:52:29 UTC 
Attachment 310611 [details] pushed as 3b14056 - region: Fix the input chooser add button sensitiveness logic