GNOME Bugzilla – Bug 754496
tracer: stats: log message structures
Last modified: 2016-01-15 11:30:02 UTC
The message is being logged only with the name, having the structure makes it possible to properly get the information about the message. The structure was named 'details' but perhaps someone has a better suggestion?
Created attachment 310556 [details] [review] tracers: stats: add message structure to output The name of the message is not enough. For example, state-change is not enough to know the transition.
Review of attachment 310556 [details] [review]: ::: plugins/tracers/gststats.c @@ +601,3 @@ "flags", G_TYPE_STRING, "", /* TODO: use gflags */ NULL), + "structure", GST_TYPE_STRUCTURE, gst_structure_new ("structure", "structure" should be "details", right?
Tracer is merged. Go ahead an push the change (with the little detail updated).
Ended up using 'structure' for the name because it is what is used in all other hooks. Changed 'details' on the code to 'structure'. commit 7c5f7173c87b56662801b38a8512c7a4250e644d Author: Thiago Santos <thiagoss@osg.samsung.com> Date: Tue Sep 1 16:39:30 2015 -0300 tracers: stats: add message structure to output The name of the message is not enough. For example, state-change is not enough to know the transition. https://bugzilla.gnome.org/show_bug.cgi?id=754496
Should we also do this for queries and events? Also, the gststats.c does actually not use this yet (remember that the idea this there there is a pair of tracer and analysis tool). Only the log tracer is meant to just dump raw details.
I had also asked to to call this details, right?
(In reply to Stefan Sauer (gstreamer, gtkdoc dev) from comment #6) > I had also asked to to call this details, right? Yes, it was named structure because it was done so in other places.