After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 754283 - gtestutils: add g_assert_cmpmem()
gtestutils: add g_assert_cmpmem()
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2015-08-29 13:04 UTC by Dan Winship
Modified: 2015-08-31 18:19 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gtestutils: add g_assert_cmpmem() (24.68 KB, patch)
2015-08-29 13:04 UTC, Dan Winship
committed Details | Review

Description Dan Winship 2015-08-29 13:04:38 UTC
Basically a copy of soup_assert_cmpmem() from
libsoup/test/test-utils.h, and I know it could also be used in a bunch
of places in NetworkManager (not to mention all the uses within glib
seen here).
Comment 1 Dan Winship 2015-08-29 13:04:42 UTC
Created attachment 310251 [details] [review]
gtestutils: add g_assert_cmpmem()

Add a test macro to compare two buffers (which are not already known
to be the same length) for equality.
Comment 2 Colin Walters 2015-08-29 13:13:40 UTC
Review of attachment 310251 [details] [review]:

Looks great!
Comment 3 Dan Winship 2015-08-31 18:19:16 UTC
Attachment 310251 [details] pushed as 9f2e3f6 - gtestutils: add g_assert_cmpmem()