GNOME Bugzilla – Bug 753964
jifmux: add "streamable" property
Last modified: 2018-11-03 13:39:37 UTC
Created attachment 309863 [details] [review] 0001-Add-support-for-the-streamable-property-which-allows.patch By default jifmux uses the GST_TAG_MERGE_KEEP mode on incoming tag events, meaning that only the first attempt to set a tag counts. This patch adds the streamable parameter, which if set to "true" will use GST_TAG_MERGE_REPLACE instead on tags. This allows tags to be set on multiple JPEGs. Patch is modelled on the flvmux element, which has identical behaviour.
Comment on attachment 309863 [details] [review] 0001-Add-support-for-the-streamable-property-which-allows.patch I don't know, this looks weird, and it's not what the 'streamable' property usually does or means. It sounds like something isn't right with tag handling somewhere. That should just be fixed then IMHO. Also, why not set the merge mode on the element yourself from the application?
When you say "why not set the merge mode on the element yourself from the application" what application are you referring to? The application I am using is gst-launch-1.0. At the core of the problem inside the jifmux element is described by this function call, which is completely missing now and is added by the patch: http://gstreamer.freedesktop.org/data/doc/gstreamer/head/gstreamer/html/GstTagSetter.html#gst-tag-setter-set-tag-merge-mode Right now, jifmux is only usable in one-shot applications like "create a thumbnail of this single video file". For applications that involve many JPEGs, such as streams, jifmux is broken, as only the very first tag value set will appear in every JPEG produced.
Created attachment 315425 [details] [review] Add support for the streamable property, which allows jifmux to support tags being written to a stream of JPEGs. By default only the first attempt to write a tag will appear in the JPEG. The previous patch missed necessary changes to the header file.
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/293.