After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 753930 - tag: add GST_TAG_CAPTURING_FOCAL_LENGTH_35_MM and handle it in exiftag
tag: add GST_TAG_CAPTURING_FOCAL_LENGTH_35_MM and handle it in exiftag
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal enhancement
: 1.9.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 767881 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2015-08-21 13:56 UTC by Aurélien Zanelli
Modified: 2016-06-20 22:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
tag: add GST_TAG_CAPTURING_FOCAL_LENGTH_35_MM tag (1.97 KB, patch)
2015-08-21 13:58 UTC, Aurélien Zanelli
committed Details | Review
exiftag: handle GST_TAG_CAPTURING_FOCAL_LENGTH_35_MM tag (4.25 KB, patch)
2015-08-21 14:01 UTC, Aurélien Zanelli
committed Details | Review

Description Aurélien Zanelli 2015-08-21 13:56:27 UTC
Exif metadata has a field to store the 35 mm equivalent focal length which is often use in photography. Currently, we don't support it in tag library.
I propose to add a new tag in it to handle this field.
Comment 1 Aurélien Zanelli 2015-08-21 13:58:47 UTC
Created attachment 309819 [details] [review]
tag: add GST_TAG_CAPTURING_FOCAL_LENGTH_35_MM tag

New tag is named GST_TAG_CAPTURING_FOCAL_LENGTH_35_MM and is stored in a double value to be consistent with GST_TAG_CAPTURING_FOCAL_LENGTH.
Comment 2 Aurélien Zanelli 2015-08-21 14:01:04 UTC
Created attachment 309820 [details] [review]
exiftag: handle GST_TAG_CAPTURING_FOCAL_LENGTH_35_MM tag

Note that associated exif tag is stored in a short, so that a precision loss occurs but I think it's better to have it as a double in GstTag for display and to be consistent with focal length.
Comment 3 Aurélien Zanelli 2016-04-28 12:47:17 UTC
ping ?
Comment 4 Thiago Sousa Santos 2016-04-28 15:47:40 UTC
Sorry for the delay here. Patches merged, just added a Since marker to the tag documentation. Thanks!

commit 928bb3b6f4bcaf7d819f369ec4d85a281df08c6a
Author: Aurélien Zanelli <aurelien.zanelli@darkosphere.fr>
Date:   Fri Aug 21 10:40:33 2015 +0200

    exiftag: handle GST_TAG_CAPTURING_FOCAL_LENGTH_35_MM tag
    
    This tag match the EXIF_TAG_FOCAL_LENGTH_IN_35_MM_FILM exif tag and is
    stored on a short. Hence there is a precision loss compared to the
    GstTag which is a double value.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=753930

commit c5a4a8382886e3cabc70f0e8afd4040745ffa34f
Author: Aurélien Zanelli <aurelien.zanelli@darkosphere.fr>
Date:   Fri Aug 21 10:39:36 2015 +0200

    tag: add GST_TAG_CAPTURING_FOCAL_LENGTH_35_MM tag
    
    It is the 35 mm equivalent focal length of the lens, mainly used in
    photography. Tag value is stored in a double value to be consistent with
    GST_TAG_CAPTURING_FOCAL_LENGTH.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=753930
Comment 5 Tim-Philipp Müller 2016-06-20 22:28:16 UTC
*** Bug 767881 has been marked as a duplicate of this bug. ***