After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 753917 - gst-omx example build failure
gst-omx example build failure
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-omx
git master
Other Linux
: Normal normal
: 1.9.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-08-21 08:43 UTC by hannes.weisbach
Modified: 2016-07-06 09:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gst-omx testegl fix (521 bytes, patch)
2015-08-21 08:43 UTC, hannes.weisbach 		needs-work Details | Review

Description hannes.weisbach 2015-08-21 08:43:45 UTC 
Created attachment 309793 [details] [review]
gst-omx testegl fix

examples/egl/testegl.c fails to build because gst_gl_handle_context_query is called with the context parameter missing:
  CC       testegl-testegl.o
testegl.c: In function ‘query_cb’:
testegl.c:1081:14: error: too few arguments to function ‘gst_gl_handle_context_query’
       return gst_gl_handle_context_query (state->pipeline, query,
              ^
In file included from /usr/local/include/gstreamer-1.0/gst/gl/gl.h:35:0,
                 from testegl.c:61:
/usr/local/include/gstreamer-1.0/gst/gl/gstglutils.h:99:10: note: declared here
 gboolean gst_gl_handle_context_query (GstElement * element, GstQuery * query,
          ^

The attached patch adds state-context as that missing parameter.
Comment 1 Matthew Waters (ystreet00) 2015-08-21 10:52:55 UTC 
Review of attachment 309793 [details] [review]:

state->context is not the same type as what gst_gl_handle_context_query expects (EGLContext vs GstGLContext **).  You'll have to wrap state->context with gst_gl_context_new_wrapped().

The current code as it stands doesn't really fit that well with how libgstgl propagates opengl contexts currently.
Comment 2 Matthew Waters (ystreet00) 2016-02-17 10:05:09 UTC 
commit 705d7722fbe05da17f2bedfdc34476382687c95f
Author: Matthew Waters <matthew@centricular.com>
Date:   Wed Feb 17 20:51:03 2016 +1100

    examples: update egl example for gstgl API changes
    
    https://bugzilla.gnome.org/show_bug.cgi?id=762053
    https://bugzilla.gnome.org/show_bug.cgi?id=753917