After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 753812 - qt: Checks for Qt5 don't require new enough version.
qt: Checks for Qt5 don't require new enough version.
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
1.5.2
Other Linux
: Normal blocker
: 1.5.91
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-08-19 10:58 UTC by Vanessa Chipirrás Navalón
Modified: 2015-08-28 18:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
configure patch checking for version 5.4.0 (1.07 KB, patch)
2015-08-19 11:39 UTC, Luis de Bethencourt 		committed Details | Review

Description Vanessa Chipirrás Navalón 2015-08-19 10:58:22 UTC 
When compiling the module bad, I got an error in gst-plugin-bad/ext/qt:

qtitem.cc: In member function 'virtual QSGNode* QtGLVideoItem::updatePaintNode(QSGNode*, QQuickItem::UpdatePaintNodeData*)':
qtitem.cc:185:14: error: 'class QSGSimpleTextureNode' has no member named 'setOwnsTexture'
     texNode->setOwnsTexture (true);
              ^

I have version 5.2.1 of qt. setOwnsTexture method is new in 5.4 

http://doc.qt.io/qt-5/qsgsimpletexturenode.html#setOwnsTexture

The checks for qt5 in configure.ac have to be updated.
Comment 1 Luis de Bethencourt 2015-08-19 11:16:46 UTC 
setOwnsTexture was added recently in

http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/commit/?id=6b8cf8419d8ea80081de8150a6b1c3cf763c4d69
Comment 2 Vanessa Chipirrás Navalón 2015-08-19 11:34:28 UTC 
My version of the operating system is:
Distributor ID:	Ubuntu
Description:	Ubuntu 14.04.3 LTS
Release:	14.04
Codename:	trusty
Comment 3 Luis de Bethencourt 2015-08-19 11:39:56 UTC 
Created attachment 309557 [details] [review]
configure patch checking for version 5.4.0
Comment 4 Vanessa Chipirrás Navalón 2015-08-19 11:57:56 UTC 
Tested the patch with QT 5.2.1 and the qt plugin isn't built. Patch works :)
Comment 5 Luis de Bethencourt 2015-08-19 12:00:08 UTC 
Review of attachment 309557 [details] [review]:

Tested.

Waiting for unfreeze
Comment 6 Sebastian Dröge (slomo) 2015-08-19 13:25:52 UTC 
There is no unfreeze until 1.6.0 :)

commit 626bd97c5aa886444ed21d6fb86467d0eeb9857e
Author: Luis de Bethencourt <luis@debethencourt.com>
Date:   Wed Aug 19 12:37:40 2015 +0100

    configure: check for Qt version
    
    Usage of QSGSimpleTextureNode::setOwnsTexture() was added in commit
    6b8cf8419d8ea80081de8150a6b1c3cf763c4d69, this function was added in
    Qt 5.4.0. Check for this version or later.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=753812