After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 753761 - map plugin uses outdated icon to mark image location
map plugin uses outdated icon to mark image location
Status: RESOLVED FIXED
Product: eog-plugins
Classification: Core
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: EOG Maintainers
EOG Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-08-18 13:03 UTC by David Evans
Modified: 2019-02-22 03:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch that makes the proposed icon substitution (424 bytes, patch)
2015-08-18 13:03 UTC, David Evans
none Details | Review

Description David Evans 2015-08-18 13:03:38 UTC
Created attachment 309459 [details] [review]
Patch that makes the proposed icon substitution

In eog-map-plugin.c, the icon "gnome-mime-image" is used to mark the position of images on the map display.  This icon is only available in the deprecated/outdated module gnome-icon-theme.  

Suggest changing to either a custom icon or one taken from adwaita-icon-theme to avoid the dependency on gnome-icon-theme.  For instance, "camera-photo-symbolic" might be a more suitable choice.

Trivial patch attached that makes this substitution.
Comment 1 Felix Riemann 2015-08-24 17:45:36 UTC
Nice catch!

I went for "image-x-generic" as replacement though.

It comes with Adwaita which means the existing GTK+ dependency should enough. Also we can the UI freeze break as it is the same image (at least in Adwaita).

The symbolic icons also are a bit problematic if you have shot several images pretty close together. As the icons are transparent they accumulate to a black blob on the map. This is a problem with how the position on the map is currently shown, but we shouldn't make it worse for now.

commit a00f6f163a3f4fd6fe8ff2d821fae286e3a872cf
Author: Felix Riemann <>
Date:   Mon Aug 24 19:37:16 2015 +0200

    map: Use a non-deprecated image icon
    
    "gnome-mime-image" requires the deprecated gnome-icon-theme
    package. Use "image-x-generic" instead, which is part of adwaita-icon-theme.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=753761
---
This problem has been fixed in our software repository. The fix will go into the next software release. Once that release is available, you may want to check for a software upgrade provided by your Linux distribution.