After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 753735 - gdaemonfile: check for the correct cancellable
gdaemonfile: check for the correct cancellable
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2015-08-17 22:01 UTC by Carlos Soriano
Modified: 2015-08-18 06:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gdaemonfile: check for the correct cancellable (1.00 KB, patch)
2015-08-17 22:01 UTC, Carlos Soriano 		committed Details | Review

Description Carlos Soriano 2015-08-17 22:01:25 UTC 
see patch
Comment 1 Carlos Soriano 2015-08-17 22:01:29 UTC 
Created attachment 309426 [details] [review]
gdaemonfile: check for the correct cancellable

We were checking for the newly created data cancellable,
which is wrong. That was causing that mounting encloused
volumes were not cancellable at all.

Check for the actual GCancellable parameter to fix it.
Comment 2 Ross Lagerwall 2015-08-17 22:04:38 UTC 
Review of attachment 309426 [details] [review]:

Looks good!
Comment 3 Carlos Soriano 2015-08-17 22:06:25 UTC 
Attachment 309426 [details] pushed as 893ce0b - gdaemonfile: check for the correct cancellable
Comment 4 Ondrej Holy 2015-08-18 06:32:38 UTC 
Review of attachment 309426 [details] [review]:

::: client/gdaemonfile.c
@@ +2078,1 @@
     data->cancellable = g_object_ref (data->cancellable);

I suppose that this line should be also changed:
-    data->cancellable = g_object_ref (data->cancellable);
+    data->cancellable = g_object_ref (cancellable);

Otherwise there will be segfault as a bonus...
Comment 5 Ondrej Holy 2015-08-18 06:34:16 UTC 
Ah you have fixed this already by commit fccc50e. Sorry for the noise...