After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 753733 - Canonicalization test failed
Canonicalization test failed
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Printers
3.17.x
Other Linux
: Normal normal
: ---
Assigned To: Marek Kašík
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-08-17 18:48 UTC by Bastien Nocera
Modified: 2015-08-18 09:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix canonicalization test (2.02 KB, patch)
2015-08-18 07:56 UTC, Marek Kašík 		committed Details | Review

Description Bastien Nocera 2015-08-17 18:48:03 UTC 
./test-canonicalization ../../../../panels/printers/canonicalization-test.txt > /dev/null

(process:27856): printers-cc-panel-ERROR **: Result for ('', 'Canon BJ-30 - CUPS+Gutenprint v5.2.9 Simplified', '', '') doesn't match 'Canon-BJ-30-3' (got: 'Canon-BJ-30')
Comment 1 Marek Kašík 2015-08-18 07:56:29 UTC 
Created attachment 309441 [details] [review]
Fix canonicalization test

Thank you for catching this. Attached is a patch fixing this bug.
Comment 2 Bastien Nocera 2015-08-18 09:01:40 UTC 
Review of attachment 309441 [details] [review]:

If the tests pass, looks fine.
Comment 3 Marek Kašík 2015-08-18 09:35:37 UTC 
Comment on attachment 309441 [details] [review]
Fix canonicalization test

(In reply to Bastien Nocera from comment #2)
> Review of attachment 309441 [details] [review] [review]:
> 
> If the tests pass, looks fine.

Thank you for the review.
Yes, the test passes with the patch. I've pushed it to master.