GNOME Bugzilla – Bug 753651
opencv: Fedora doesn't find haar cascade files
Last modified: 2015-08-20 14:06:01 UTC
In Fedora the haar cascade files are in /usr/share/OpenCV/, meanwhile debian/arch/probably-others have them in /usr/share/opencv. Fix the HAAR_CASCADES_DIR definition to point to the right location in all distributions/platforms.
Looks like it is hardcoded since 2012: http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/commit/?id=d4509a2fda5bff72201e393f774ebfed8f0137cd We need to fix the build system to set this definition based on the pkg-config information.
Created attachment 309400 [details] [review] Check which path to use in configure.ac
Review of attachment 309400 [details] [review]: That's neat and clean, thanks !
(I also tested it of course ;-P)
Review of attachment 309400 [details] [review]: commit 07ee52db5dbddf35ab22199a1960e9f5cc8aae73 Author: Luis de Bethencourt <luis@debethencourt.com> Date: Mon Aug 17 17:38:15 2015 +0100 opencv: support alternative path convention Some distributions store OpenCV files in /usr/share/opencv and some others (and default when building from source) install them in /usr/share/OpenCV. Support both to find cascade files. https://bugzilla.gnome.org/show_bug.cgi?id=753651
Thanks for reviewing and testing Nicolas :)
Created attachment 309706 [details] [review] Use test -d instead of AC_CHECK_fiLE AC_CHECK_FILE breaks cross compilation. This is bad.
Created attachment 309711 [details] [review] updated opencv data path check patch The test -d replacement works. Also fixing the OpenCV path check by using PKG_CONFIG_SYSROOT_DIR.
Review of attachment 309706 [details] [review]: Carlos' patch is better.
Review of attachment 309711 [details] [review]: Works well.
Review of attachment 309711 [details] [review]: Carlos, We don't use Signed-off tags in GStreamer, and we usually add the URL of the bug related to the commit if there was one. Thanks! :) commit 0cc2156572755626a170ad99345647faf4d43a84 Author: Carlos Rafael Giani <dv@pseudoterminal.org> Date: Thu Aug 20 14:09:37 2015 +0200 opencv: Fix OpenCV data path check to work with cross compilation https://bugzilla.gnome.org/show_bug.cgi?id=753651
Right, I forgot about that, sorry. I am just so used to the signed-off stuff by now, it almost happens automatically :)
*** Bug 753849 has been marked as a duplicate of this bug. ***