After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 753617 - splitmuxsink: allow non-video streams to serve as reference
splitmuxsink: allow non-video streams to serve as reference
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal enhancement
: 1.6.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-08-14 11:15 UTC by George Kiagiadakis
Modified: 2015-10-02 14:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
splitmuxsink: allow non-video streams to serve as reference (7.46 KB, patch)
2015-08-14 11:15 UTC, George Kiagiadakis 		accepted-commit_after_freeze Details | Review

Description George Kiagiadakis 2015-08-14 11:15:10 UTC 
Created attachment 309253 [details] [review]
splitmuxsink: allow non-video streams to serve as reference

splitmuxsink at the moment requires a video stream to be present. This patch lifts this restriction and allows the first available stream to be used as a reference.

This works fine, although it could probably be done better, avoiding all the overhead of the GOP collecting logic. In an audio stream, every buffer is considered a "keyframe".
Comment 1 Jan Schmidt 2015-08-22 10:42:07 UTC 
Review of attachment 309253 [details] [review]:

Looks good, thanks!
Comment 2 Jan Schmidt 2015-10-02 14:45:45 UTC 
Pushed, thanks!

commit 76634e89f0ffcb63e62a83b4c1e55f106e9b7f67
Author: Ramiro Polla <ramiro.polla@collabora.co.uk>
Date:   Wed Apr 29 18:23:28 2015 +0100

    splitmuxsink: allow non-video streams to serve as reference
    
    In the absence of a video stream, the first stream will be used as
    reference.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=753617