After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 753521 - g_subprocess_launcher_set_environ misses argument annotations
g_subprocess_launcher_set_environ misses argument annotations
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: introspection
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2015-08-11 14:55 UTC by Alberto Ruiz
Modified: 2017-09-11 19:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
adds annotations for g_subprocess_launcher_set_environ (938 bytes, patch)
2015-08-11 14:55 UTC, Alberto Ruiz 		none Details | Review
adds annotations for g_subprocess_launcher_set_environ (904 bytes, patch)
2015-08-15 00:33 UTC, Alberto Ruiz 		committed Details | Review

Description Alberto Ruiz 2015-08-11 14:55:52 UTC 
Created attachment 309076 [details] [review]
adds annotations for g_subprocess_launcher_set_environ

g_subprocess_launcher_set_environ misses some annotations that makes it generate the wrong bindings in certain languages.
Comment 1 Christian Persch 2015-08-11 16:22:47 UTC 
Comment on attachment 309076 [details] [review]
adds annotations for g_subprocess_launcher_set_environ

> (element-type utf8) 

There is no requirement that environment strings must be UTF-8.
Comment 2 desrt's bugzilla bot 2015-08-12 09:16:32 UTC 
Review of attachment 309076 [details] [review]:

indeed.
Comment 3 Alberto Ruiz 2015-08-15 00:33:21 UTC 
Created attachment 309314 [details] [review]
adds annotations for g_subprocess_launcher_set_environ

This patch removes the utf8 element type annotation from the previous patch.
Comment 4 Philip Withnall 2017-09-11 19:22:08 UTC 
Review of attachment 309314 [details] [review]:

This was partially done in commit 7bf31065cc, but the (transfer none) annotation is still missing.  I’ll update and push the patch.
Comment 5 Philip Withnall 2017-09-11 19:24:17 UTC 
I rebased the patch and shortened the commit subject a bit.