After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 753450 - audioecho: unused local variable in set_property function
audioecho: unused local variable in set_property function
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 1.5.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-08-10 11:30 UTC by Prashant Gotarne
Modified: 2015-08-16 13:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
audioecho: removed unused variable in set_property (1.13 KB, patch)
2015-08-10 11:32 UTC, Prashant Gotarne 		committed Details | Review

Description Prashant Gotarne 2015-08-10 11:30:16 UTC 
local variable 'delay' is unused in switch case PROP_MAX_DELAY.
Variable 'delay' is initialized with the self->delay and 
used to set the value of self->delay later without changes.
Comment 1 Prashant Gotarne 2015-08-10 11:32:13 UTC 
Created attachment 309006 [details] [review]
audioecho: removed unused variable in set_property

please review the patch
Comment 2 Luis de Bethencourt 2015-08-10 12:34:20 UTC 
Review of attachment 309006 [details] [review]:

commit cde1f12ad3d470ea2265d1c91bc832f41da66c06
Author: Prashant Gotarne <ps.gotarne@samsung.com>
Date:   Mon Aug 10 17:10:42 2015 +0530

    audioecho: removed unused variable in set_property

    unused local variable 'delay' is removed.

    https://bugzilla.gnome.org/show_bug.cgi?id=753450
Comment 3 Luis de Bethencourt 2015-08-10 12:34:47 UTC 
Thanks! :)